Disable --deoptimize-every/--stacktrace-every in kernel isolate

runtime/vm/flow_graph_compiler.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_XXX.
 
 #include "vm/flow_graph_compiler.h"
 
 #include "vm/bit_vector.h"
 #include "vm/cha.h"
 #include "vm/compiler.h"
 #include "vm/dart_entry.h"
 #include "vm/debugger.h"
 #include "vm/deopt_instructions.h"
 #include "vm/exceptions.h"
 #include "vm/flags.h"
 #include "vm/flow_graph_allocator.h"
 #include "vm/il_printer.h"
 #include "vm/intrinsifier.h"
+#include "vm/kernel_isolate.h"
 #include "vm/locations.h"
 #include "vm/log.h"
 #include "vm/longjump.h"
 #include "vm/object_store.h"
 #include "vm/parser.h"
 #include "vm/raw_object.h"
 #include "vm/resolver.h"
 #include "vm/stack_frame.h"
 #include "vm/stub_code.h"
 #include "vm/symbols.h"
@@ skipping 264 matching lines @@
 }
 
 bool FlowGraphCompiler::CanOSRFunction() const {
   return isolate()->use_osr() && CanOptimizeFunction() && !is_optimizing();
 }
 
 bool FlowGraphCompiler::ForceSlowPathForStackOverflow() const {
 #if !defined(PRODUCT)
   if ((FLAG_stacktrace_every > 0) || (FLAG_deoptimize_every > 0) ||
       (isolate()->reload_every_n_stack_overflow_checks() > 0)) {
-    return true;
+#if defined(DART_PRECOMPILED_RUNTIME)

[kustermann, 2017/08/23 11:22:15]

Does someone know why the other FlowGraphCompiler code would be included in
DART_PRECOMPILED_RUNTIME?

[Vyacheslav Egorov (Google), 2017/08/23 18:41:25]

I think it's just compiled and should be thrown by a linker. 

Aske's change does a proper coarse grained ifdef-ing, but that got reverted.

[kustermann, 2017/08/24 09:15:02]

Makes sense.

+    const bool is_kernel_isolate = false;
+#else
+    // Certain flags should not effect the kernel isolate itself.  They might be
+    // used by tests via the "VMOptions=--..." annotation to test VM
+    // functionality in the main isolate.
+    const bool is_kernel_isolate = KernelIsolate::IsKernelIsolate(isolate());

[Vyacheslav Egorov (Google), 2017/08/23 18:41:25]

What about VMService isolate?

[kustermann, 2017/08/24 09:15:02]

done

+#endif  // !defined(DART_PRECOMPILED_RUNTIME)
+    if (!is_kernel_isolate) {
+      return true;
+    }
   }
   if (FLAG_stacktrace_filter != NULL &&
       strstr(parsed_function().function().ToFullyQualifiedCString(),
              FLAG_stacktrace_filter) != NULL) {
     return true;
   }
   if (is_optimizing() && FLAG_deoptimize_filter != NULL &&
       strstr(parsed_function().function().ToFullyQualifiedCString(),
              FLAG_deoptimize_filter) != NULL) {
     return true;
@@ skipping 1630 matching lines @@
   return true;
 }
 
 void FlowGraphCompiler::FrameStateClear() {
   ASSERT(!is_optimizing());
   frame_state_.TruncateTo(0);
 }
 #endif  // defined(DEBUG) && !defined(TARGET_ARCH_DBC)
 
 }  // namespace dart