Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2997273002: Adjusted treatment of timeout with absolute build number. (Closed)

Created:
3 years, 4 months ago by eernst
Modified:
3 years, 4 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Adjusted treatment of timeout with absolute build number. With `dart bin/bot.dart compare-failures ..`, skipping a relative build number (like -1) used to be supported (and reported with --verbose). This CL uses the same treatment for absolute build numbers: The output includes information about earlier builds anyway, so it makes sense to skip in the same manner here. R=johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/6e22b589bf963ada0c12f7d5a6bf689e77bff3a9

Patch Set 1 #

Patch Set 2 : Adjusted treatment of build number skipping: `print` when absolute #

Patch Set 3 : Fixed thinko #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M tools/gardening/lib/src/client.dart View 1 2 1 chunk +9 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
eernst
After some experiments, I think we should just do the same thing for abs. as ...
3 years, 4 months ago (2017-08-21 12:16:20 UTC) #2
Johnni Winther
lgtm
3 years, 4 months ago (2017-08-21 12:50:30 UTC) #3
eernst
3 years, 4 months ago (2017-08-21 13:09:56 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
6e22b589bf963ada0c12f7d5a6bf689e77bff3a9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698