Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(653)

Unified Diff: tools/gardening/lib/src/client.dart

Issue 2997273002: Adjusted treatment of timeout with absolute build number. (Closed)
Patch Set: Fixed thinko Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gardening/lib/src/client.dart
diff --git a/tools/gardening/lib/src/client.dart b/tools/gardening/lib/src/client.dart
index eb09ac8f38554dff970e3ddef0a6a66ebdd1d277..773c2d01f880d9491becd017fa86e4f037c2541f 100644
--- a/tools/gardening/lib/src/client.dart
+++ b/tools/gardening/lib/src/client.dart
@@ -32,13 +32,18 @@ class HttpBuildbotClient implements BuildbotClient {
Future<BuildResult> readResult(BuildUri buildUri) async {
int skips = 0;
Duration timeout;
- if (buildUri.buildNumber < 0) {
- timeout = new Duration(seconds: 1);
- }
+ timeout = new Duration(seconds: 1);
void skipToPreviousBuildNumber() {
BuildUri prevBuildUri = buildUri.prev();
- log('Skip build number on ${buildUri} -> ${prevBuildUri.buildNumber}');
+ String message =
+ 'Skip build number on ${buildUri} -> ${prevBuildUri.buildNumber}';
+ // Skipping is more serious with an absolute than a relative build.
+ if (buildUri.buildNumber < 0) {
+ log(message);
+ } else {
+ print(message);
+ }
buildUri = buildUri.prev();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698