Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Issue 299723002: Revert of Web Animations: Timeline should not advance during task execution (Closed)

Created:
6 years, 7 months ago by dstockwell
Modified:
6 years, 7 months ago
Reviewers:
Noel Gordon
CC:
blink-reviews, rwlbuis, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, sof, eae+blinkwatch, dglazkov+blink, dstockwell, Timothy Loh, blink-reviews-dom_chromium.org, darktears, Steve Block, Eric Willigers, abarth-chromium
Visibility:
Public.

Description

Revert of Web Animations: Timeline should not advance during task execution (https://codereview.chromium.org/275753002/) Reason for revert: Broke telemetry_untitests and others: http://build.chromium.org/p/chromium.webkit/builders/Win7%20%28dbg%29/builds/14161/steps/telemetry_unittests/logs/stdio Original issue's description: > Web Animations: Timeline should not advance during task execution > > Previously the animation clock was only frozen during animation frame > callbacks. This meant that the timeline was able to advance during other > tasks. > > This patch allows the clock to advance once per task, either to the > compositor supplied frame start time or to an approximation of the next > expected frame time. > > http://dev.w3.org/fxtf/web-animations/#script-execution-and-live-updates-to-the-model > > This is a reland of r173583[1], the previous patch hit added assertions > due to double rounding issues, the new approach avoids these. Also ensures > that other unit tests see a non-zero currentTime (seen in some webkit_unit_test > runs on Android). > > [1] https://src.chromium.org/viewvc/blink?view=rev&revision=173583 > BUG=367903 > TBR=abarth > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174346 TBR=noel@chromium.org NOTREECHECKS=true NOTRY=true BUG=367903, 375231 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174392

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -127 lines) Patch
M Source/core/animation/AnimationClock.h View 1 chunk +18 lines, -12 lines 0 comments Download
M Source/core/animation/AnimationClock.cpp View 1 chunk +5 lines, -34 lines 0 comments Download
M Source/core/animation/AnimationClockTest.cpp View 2 chunks +22 lines, -78 lines 0 comments Download
M Source/core/animation/DocumentAnimations.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/dom/Document.h View 4 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/Document.cpp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dstockwell
Created Revert of Web Animations: Timeline should not advance during task execution
6 years, 7 months ago (2014-05-20 18:05:32 UTC) #1
dstockwell
The CQ bit was checked by dstockwell@chromium.org
6 years, 7 months ago (2014-05-20 18:06:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/299723002/1
6 years, 7 months ago (2014-05-20 18:07:32 UTC) #3
commit-bot: I haz the power
Change committed as 174392
6 years, 7 months ago (2014-05-20 18:08:04 UTC) #4
Noel Gordon
6 years, 7 months ago (2014-05-20 23:15:32 UTC) #5
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698