Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 2997163002: Revert of [Android] Open a tab in the background from Browser Actions if ChromeTabbedActivity... (Closed)

Created:
3 years, 4 months ago by bengr
Modified:
3 years, 4 months ago
Reviewers:
Ted C, Yusuf, ltian
CC:
chromium-reviews, srahim+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Android] Open a tab in the background from Browser Actions if ChromeTabbedActivity is available (patchset #13 id:240001 of https://codereview.chromium.org/2931433004/ ) Reason for revert: Breaks testOpenMultipleTabInBackgroundWhenChromeAvailable on tablets. Original issue's description: > [Android] Open a tab in the background from Browser Actions if ChromeTabbedActivity is available > > Implements the function that opens a tab for the given url in the > background of Chrome from Browser Actions menu. Also add a new > TabLaunchType (Browser Actions) which does not show transition and > always add to the top of the tab list. Besides, postpones operation > by showing a ProgressDialog to block UI until native libraries are > loaded. > > BUG=730305 > > Review-Url: https://codereview.chromium.org/2931433004 > Cr-Commit-Position: refs/heads/master@{#494316} > Committed: https://chromium.googlesource.com/chromium/src/+/fc32a59653e65cee968472d8c91fa060fdf981d9 TBR=tedchoc@chromium.org,yusufo@chromium.org,ltian@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=730305, 756509 Review-Url: https://codereview.chromium.org/2997163002 Cr-Commit-Position: refs/heads/master@{#495242} Committed: https://chromium.googlesource.com/chromium/src/+/a29ddf2ebcc01f3a21121f73b6155ccc812a4275

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -685 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/browseractions/BrowserActionActivity.java View 5 chunks +10 lines, -26 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/browseractions/BrowserActionsContextMenuHelper.java View 9 chunks +20 lines, -109 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/browseractions/BrowserActionsContextMenuItemDelegate.java View 7 chunks +13 lines, -61 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuListAdapter.java View 2 chunks +14 lines, -21 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java View 2 chunks +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModel.java View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelOrderController.java View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/android/java_sources.gni View 2 chunks +1 line, -2 lines 0 comments Download
D chrome/android/javatests/src/org/chromium/chrome/browser/browseractions/BrowserActionActivityTest.java View 1 chunk +0 lines, -353 lines 0 comments Download
A chrome/android/junit/src/org/chromium/chrome/browser/browseractions/BrowserActionActivityTest.java View 1 chunk +103 lines, -0 lines 0 comments Download
D chrome/android/junit/src/org/chromium/chrome/browser/browseractions/BrowserActionsIntentTest.java View 1 chunk +0 lines, -102 lines 0 comments Download

Messages

Total messages: 6 (4 generated)
bengr
Created Revert of [Android] Open a tab in the background from Browser Actions if ChromeTabbedActivity ...
3 years, 4 months ago (2017-08-17 18:02:09 UTC) #2
commit-bot: I haz the power
3 years, 4 months ago (2017-08-17 18:37:02 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a29ddf2ebcc01f3a21121f73b615...

Powered by Google App Engine
This is Rietveld 408576698