Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 2997073002: Correctly update positions when adding edits before them (issue 30444) (Closed)

Created:
3 years, 4 months ago by Brian Wilkerson
Modified:
3 years, 4 months ago
Reviewers:
devoncarew
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Correctly update positions when adding edits before them (issue 30444) R=devoncarew@google.com Committed: https://github.com/dart-lang/sdk/commit/d87fcfd23394e2e8c2f04a72a9b3a384b750b667

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -26 lines) Patch
M pkg/analysis_server/test/services/correction/fix_test.dart View 1 chunk +12 lines, -0 lines 0 comments Download
M pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_core.dart View 10 chunks +48 lines, -15 lines 0 comments Download
M pkg/analyzer_plugin/lib/utilities/change_builder/change_builder_core.dart View 2 chunks +0 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 4 months ago (2017-08-16 16:42:02 UTC) #2
devoncarew
lgtm
3 years, 4 months ago (2017-08-16 17:20:22 UTC) #3
Brian Wilkerson
3 years, 4 months ago (2017-08-16 17:29:31 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d87fcfd23394e2e8c2f04a72a9b3a384b750b667 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698