Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Unified Diff: pkg/analyzer_plugin/lib/utilities/change_builder/change_builder_core.dart

Issue 2997073002: Correctly update positions when adding edits before them (issue 30444) (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_core.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer_plugin/lib/utilities/change_builder/change_builder_core.dart
diff --git a/pkg/analyzer_plugin/lib/utilities/change_builder/change_builder_core.dart b/pkg/analyzer_plugin/lib/utilities/change_builder/change_builder_core.dart
index 7d4ad63285fa860f8b28726e92876a1c728888f1..39e5b4f4d41487b5c8287ffc6ca560bbf5ddb194 100644
--- a/pkg/analyzer_plugin/lib/utilities/change_builder/change_builder_core.dart
+++ b/pkg/analyzer_plugin/lib/utilities/change_builder/change_builder_core.dart
@@ -67,12 +67,6 @@ abstract class EditBuilder {
/**
* Set the selection to the given location within the edit being built.
- *
- * This method only works correctly if all of the edits that will applied to
- * text before the current edit have already been created. Those edits are
- * needed in order to convert the current offset (as of the time this method
- * is invoked) into an offset relative to the text resulting from applying all
- * of the edits.
*/
void selectHere();
@@ -117,11 +111,6 @@ abstract class FileEditBuilder {
* source. This is typically used to include pre-existing regions of text in a
* group. If the region to be included is part of newly generated text, then
* the method [EditBuilder.addLinkedEdit] should be used instead.
- *
- * This method only works correctly if all of the edits that will applied to
- * text before the given range have already been created. Those edits are
- * needed in order to convert the range into a range relative to the text
- * resulting from applying all of the edits.
*/
void addLinkedPosition(SourceRange range, String groupName);
« no previous file with comments | « pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_core.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698