Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2997043002: Include build revision in BuildResult (Closed)

Created:
3 years, 4 months ago by Johnni Winther
Modified:
3 years, 4 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -4 lines) Patch
M tools/gardening/lib/src/buildbot_loading.dart View 4 chunks +6 lines, -1 line 0 comments Download
M tools/gardening/lib/src/buildbot_structures.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M tools/gardening/test/buildbot_data_test.dart View 3 chunks +12 lines, -0 lines 0 comments Download
M tools/gardening/test/test_client.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 4 months ago (2017-08-16 13:20:49 UTC) #2
floitsch
LGTM!
3 years, 4 months ago (2017-08-16 13:23:05 UTC) #3
Johnni Winther
3 years, 4 months ago (2017-08-16 13:41:31 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a708c1943faa8f23025c796f5430e8536826a8c7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698