Index: tools/gardening/test/buildbot_data_test.dart |
diff --git a/tools/gardening/test/buildbot_data_test.dart b/tools/gardening/test/buildbot_data_test.dart |
index 7141683f508afa03d7f8e409f6829550953a52cd..5a76a7eae273b48cca2ec31ac1c3a5b0102a0e9b 100644 |
--- a/tools/gardening/test/buildbot_data_test.dart |
+++ b/tools/gardening/test/buildbot_data_test.dart |
@@ -20,6 +20,7 @@ main(List<String> args) async { |
Bot bot = new Bot(logdog: useLogdog); |
List<String> failingUris = <String>[]; |
+ List<String> missingBuildNumbers = <String>[]; |
List<BuildUri> buildUris = <BuildUri>[]; |
for (BuildGroup buildGroup in buildGroups) { |
for (BuildSubgroup buildSubgroup in buildGroup.subgroups) { |
@@ -33,6 +34,11 @@ main(List<String> args) async { |
BuildResult result = buildResults[index]; |
if (result == null) { |
failingUris.add('$buildUri'); |
+ } else { |
+ if (result.buildNumber == null) { |
+ missingBuildNumbers.add('$buildUri'); |
+ } |
+ Expect.isNotNull(result.buildRevision, "No build revision in $buildUri"); |
} |
} |
// TODO(johnniwinther): Find out why these steps cannot be read. |
@@ -46,5 +52,11 @@ main(List<String> args) async { |
], failingUris, |
"Unexpected failing buildbot uris:\n ${failingUris.join('\n ')}"); |
+ Expect.setEquals( |
+ [], |
+ missingBuildNumbers, |
+ "Unexpected missing build numbers in:\n " |
+ "${missingBuildNumbers.join('\n ')}"); |
+ |
bot.close(); |
} |