Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1792)

Unified Diff: chrome/browser/about_flags.cc

Issue 299703016: Gate disabling nacl code on proper gyp flags, etc. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove speculative changes from review Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index 0a9aac0ee91f60ae0e2b9ebd43548145f0ca5702..56f82466655fced638ffc86946ee6effd6dde79e 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -589,12 +589,13 @@ const Experiment kExperiments[] = {
kOsAll,
MULTI_VALUE_TYPE(kEnableAcceleratedFixedRootBackgroundChoices)
},
- // TODO(bbudge): When NaCl is on by default, remove this flag entry.
+ // Native client is compiled out when DISABLE_NACL is defined.
+#if !defined(DISABLE_NACL)
{
"enable-nacl", // FLAGS:RECORD_UMA
IDS_FLAGS_ENABLE_NACL_NAME,
IDS_FLAGS_ENABLE_NACL_DESCRIPTION,
- kOsDesktop,
+ kOsAll,
SINGLE_VALUE_TYPE(switches::kEnableNaCl)
},
{
@@ -618,6 +619,7 @@ const Experiment kExperiments[] = {
kOsDesktop,
MULTI_VALUE_TYPE(kNaClDebugMaskChoices)
},
+#endif
{
"extension-apis", // FLAGS:RECORD_UMA
IDS_FLAGS_EXPERIMENTAL_EXTENSION_APIS_NAME,
@@ -895,6 +897,8 @@ const Experiment kExperiments[] = {
kOsDesktop,
SINGLE_VALUE_TYPE(switches::kEnableDownloadResumption)
},
+ // Native client is compiled out when DISABLE_NACL is defined.
+#if !defined(DISABLE_NACL)
{
"allow-nacl-socket-api",
IDS_FLAGS_ALLOW_NACL_SOCKET_API_NAME,
@@ -902,6 +906,7 @@ const Experiment kExperiments[] = {
kOsDesktop,
SINGLE_VALUE_TYPE_AND_VALUE(switches::kAllowNaClSocketAPI, "*")
},
+#endif
{
"force-device-scale-factor",
IDS_FLAGS_FORCE_HIGH_DPI_NAME,

Powered by Google App Engine
This is Rietveld 408576698