components/nacl/loader/nacl_main.cc - Issue 299703016: Gate disabling nacl code on proper gyp flags, etc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/nacl/loader/nacl_main.cc

Issue 299703016: Gate disabling nacl code on proper gyp flags, etc. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove speculative changes from review Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/nacl/loader/nacl_main.cc

diff --git a/components/nacl/loader/nacl_main.cc b/components/nacl/loader/nacl_main.cc

index 15b6fd2dc8cb16e6497876978addc6cca74812b7..9b8fbbcdd4fb9af053a941ecd610cb8519bb51a6 100644

--- a/components/nacl/loader/nacl_main.cc

+++ b/components/nacl/loader/nacl_main.cc

@@ -27,7 +27,7 @@ int NaClMain(const content::MainFunctionParams& parameters) {

base::PowerMonitor power_monitor(power_monitor_source.Pass());

base::HighResolutionTimerManager hi_res_timer_manager;

-#if defined(OS_WIN) || defined(OS_MACOSX) || defined(OS_LINUX)

+#if defined(OS_WIN) || defined(OS_MACOSX) || defined(OS_LINUX) || defined(OS_ANDROID)

darin (slow to review) 2014/05/30 22:41:29 nit: 80 char line length

sehr 2014/06/02 20:03:35 Fixed.

NaClMainPlatformDelegate platform(parameters);

bool no_sandbox = parsed_command_line.HasSwitch(switches::kNoSandbox);

« no previous file with comments | « chrome/browser/about_flags.cc ('k') | components/nacl/nacl_defines.gypi » ('j') | no next file with comments »