Gate disabling nacl code on proper gyp flags, etc.

Gate disabling nacl code on proper gyp flags, etc.

Background: I am currently trying to test NaCl in clank by setting disable_nacl=0 and enable_plugins=1 in gyp.  Some of the code required to get this to work is guarded under overly-specific OS==android and similar constructs.  This first CL enables a coherent build with the flags set to gyp, but does not yet turn the functionality on completely.  A sampling of issues fixed:

1) std:: prefix is more strictly observed on android
2) define NACL_LINUX, etc., is needed for nacl code
3) properly guard flag-setting code

BUG= https://code.google.com/p/nativeclient/issues/detail?id=3032
R=bradnelson@google.com, darin@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274839

[sehr, 2014-05-30 22:20:59]

Thanks in advance for comments.  PTAL.

[darin (slow to review), 2014-05-30 22:41:28]

LGTM

https://codereview.chromium.org/299703016/diff/60001/components/nacl/loader/n...
File components/nacl/loader/nacl_main.cc (right):

https://codereview.chromium.org/299703016/diff/60001/components/nacl/loader/n...
components/nacl/loader/nacl_main.cc:30: #if defined(OS_WIN) ||
defined(OS_MACOSX) || defined(OS_LINUX) || defined(OS_ANDROID)
nit: 80 char line length

[jam, 2014-05-30 23:42:31]

i'm only owner in chrome, but darin is toplevel owner so removing myself

[bradn, 2014-05-31 00:05:45]

lgtm (with the 80 col fix)

[sehr, 2014-06-02 20:03:35]

Thanks for the reviews.  Waiting for trybots.

https://codereview.chromium.org/299703016/diff/60001/components/nacl/loader/n...
File components/nacl/loader/nacl_main.cc (right):

https://codereview.chromium.org/299703016/diff/60001/components/nacl/loader/n...
components/nacl/loader/nacl_main.cc:30: #if defined(OS_WIN) ||
defined(OS_MACOSX) || defined(OS_LINUX) || defined(OS_ANDROID)
On 2014/05/30 22:41:29, darin wrote:
> nit: 80 char line length

Fixed.

[sehr, 2014-06-02 23:27:26]

Trybots turned up a couple of small issues.  New version uploaded.  PTAL.  Sorry
for the churn.

[sehr, 2014-06-03 15:16:15]

The CQ bit was checked by sehr@chromium.org

[commit-bot: I haz the power, 2014-06-03 15:16:39]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sehr@chromium.org/299703016/120001

[commit-bot: I haz the power, 2014-06-03 19:48:26]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[sehr, 2014-06-04 15:40:04]

Committed patchset #7 manually as r274839 (presubmit successful).