Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1357)

Unified Diff: components/nacl/nacl_defines.gypi

Issue 299703016: Gate disabling nacl code on proper gyp flags, etc. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix guard on flags code Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/nacl/loader/nacl_main.cc ('k') | components/nacl/renderer/json_manifest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/nacl/nacl_defines.gypi
diff --git a/components/nacl/nacl_defines.gypi b/components/nacl/nacl_defines.gypi
index fdcdf960c0bc903f2c199d5e2660cfdb4e541588..9a17eaf9e9ae3244b802cac1a7ad8ee99fe2add9 100644
--- a/components/nacl/nacl_defines.gypi
+++ b/components/nacl/nacl_defines.gypi
@@ -5,32 +5,43 @@
{
'variables': {
'conditions': [
- ['OS=="win"', {
+ ['disable_nacl==1', {
'nacl_defines': [
- 'NACL_WINDOWS=1',
- 'NACL_LINUX=0',
- 'NACL_OSX=0',
],
- }],
- ['OS=="linux"', {
- 'nacl_defines': [
- 'NACL_WINDOWS=0',
- 'NACL_LINUX=1',
- 'NACL_OSX=0',
- ],
- }],
- ['OS=="mac"', {
- 'nacl_defines': [
- 'NACL_WINDOWS=0',
- 'NACL_LINUX=0',
- 'NACL_OSX=1',
- ],
- }],
- # "disabled_nacl" is always set to "1" when building for "ios" or android,
- # so set "nacl_defines" to the empty list to ensure the variable is
- # always defined.
- ['OS=="ios" or OS=="android"', {
- 'nacl_defines': [
+ }, {
+ 'conditions': [
+ ['OS=="win"', {
+ 'nacl_defines': [
+ 'NACL_WINDOWS=1',
+ 'NACL_LINUX=0',
+ 'NACL_OSX=0',
+ 'NACL_ANDROID=0',
+ ],
+ }],
+ ['OS=="linux"', {
+ 'nacl_defines': [
+ 'NACL_WINDOWS=0',
+ 'NACL_LINUX=1',
+ 'NACL_OSX=0',
+ 'NACL_ANDROID=0',
+ ],
+ }],
+ ['OS=="mac"', {
+ 'nacl_defines': [
+ 'NACL_WINDOWS=0',
+ 'NACL_LINUX=0',
+ 'NACL_OSX=1',
+ 'NACL_ANDROID=0',
+ ],
+ }],
+ ['OS=="android"', {
+ 'nacl_defines': [
+ 'NACL_WINDOWS=0',
+ 'NACL_LINUX=1',
+ 'NACL_OSX=0',
+ 'NACL_ANDROID=1',
+ ],
+ }],
],
}],
# TODO(mcgrathr): This duplicates native_client/build/common.gypi;
« no previous file with comments | « components/nacl/loader/nacl_main.cc ('k') | components/nacl/renderer/json_manifest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698