Issue 299703005: Revert 271773 "Fix RlzLibTest by setting OmniboxLog.is_popup_ope..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 299703005: Revert 271773 "Fix RlzLibTest by setting OmniboxLog.is_popup_ope..." (Closed)

Created:
6 years, 7 months ago by Nicolas Zea

Modified:
6 years, 7 months ago

Reviewers:
yao

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 271773 "Fix RlzLibTest by setting OmniboxLog.is_popup_ope..." Breaks official mac builder. See bug. > Fix RlzLibTest by setting OmniboxLog.is_popup_open to be true in function SimulateOmniboxUsage. > > BUG=369249 > > Review URL: https://codereview.chromium.org/282293003 TBR=yiyaoliu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271790

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -4 lines)			Patch
	M	trunk/src/chrome/browser/rlz/rlz_unittest.cc	View		1 chunk	+1 line, -4 lines	0 comments	Download

Total messages: 2 (0 generated)

Nicolas Zea

6 years, 7 months ago (2014-05-21 01:27:41 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r271790 (tree was closed).