Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 282293003: Fix RlzLibTest (Closed)

Created:
6 years, 7 months ago by yao
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Fix RlzLibTest by setting OmniboxLog.is_popup_open to be true in function SimulateOmniboxUsage. BUG=369249 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271773

Patch Set 1 #

Patch Set 2 : Comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/browser/rlz/rlz_unittest.cc View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
yao
Hi Mark, Sorry for the delay. There were a few release blockers assigned to me ...
6 years, 7 months ago (2014-05-20 14:16:12 UTC) #1
Mark P
lgtm
6 years, 7 months ago (2014-05-20 18:28:35 UTC) #2
yao
The CQ bit was checked by yiyaoliu@chromium.org
6 years, 7 months ago (2014-05-20 18:31:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yiyaoliu@chromium.org/282293003/20001
6 years, 7 months ago (2014-05-20 18:33:50 UTC) #4
yao
The CQ bit was unchecked by yiyaoliu@chromium.org
6 years, 7 months ago (2014-05-20 18:46:51 UTC) #5
yao
+roger for owner's review. Thanks!
6 years, 7 months ago (2014-05-20 18:48:03 UTC) #6
Roger Tawa OOO till Jul 10th
lgtm
6 years, 7 months ago (2014-05-20 19:07:21 UTC) #7
yao
The CQ bit was checked by yiyaoliu@chromium.org
6 years, 7 months ago (2014-05-20 19:15:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yiyaoliu@chromium.org/282293003/20001
6 years, 7 months ago (2014-05-20 19:17:02 UTC) #9
commit-bot: I haz the power
Change committed as 271773
6 years, 7 months ago (2014-05-20 22:03:02 UTC) #10
yao
6 years, 7 months ago (2014-05-21 17:12:16 UTC) #11
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/296453014/ by yiyaoliu@chromium.org.

The reason for reverting is: fails to compile on the official mac builder, 
bug: 375526
http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Mac/bu...
.

Powered by Google App Engine
This is Rietveld 408576698