Build ChromeVox using gyp.

Build ChromeVox using gyp.

This adds tools and gyp targets to build ChromeVox directly from its original
source in the Chromium repository instead of using precompiled obfuscated
JavaScript binaries.  In addition, this adds infrastructure to run
ChromeVox 'unbundled' inside of a chromeos build.

Note that this is still experimental and not enabled by default.  Also, the
manifest to run ChromeVox unbundled is not provided yet.

BUG=371692
R=dtseng@chromium.org,dmazzoni@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272146

[dmazzoni, 2014-05-21 17:42:17]

lgtm

https://codereview.chromium.org/299703003/diff/20001/chrome/browser/resources...
File chrome/browser/resources/chromeos/chromevox/chromevox.gyp (right):

https://codereview.chromium.org/299703003/diff/20001/chrome/browser/resources...
chrome/browser/resources/chromeos/chromevox/chromevox.gyp:9: # Whether to
compress the 4 main ChroeVox scripts.  applicable if
ChroeVox -> ChromeVox, and capitalize "applicable"

https://codereview.chromium.org/299703003/diff/20001/chrome/browser/resources...
File chrome/browser/resources/chromeos/chromevox/tools/jsbundler.py (right):

https://codereview.chromium.org/299703003/diff/20001/chrome/browser/resources...
chrome/browser/resources/chromeos/chromevox/tools/jsbundler.py:21: - bundle: a
cocatenation of all the files, separated by newlines.
cocatenation -> concatenation

https://codereview.chromium.org/299703003/diff/20001/chrome/browser/resources...
chrome/browser/resources/chromeos/chromevox/tools/jsbundler.py:193: '''Copies a
list of sources to a destination directory.'''
I think this function should be called HardLinkOrCopyFiles and the helper should
be LinkOrCopyOneFile

https://codereview.chromium.org/299703003/diff/20001/chrome/browser/resources...
chrome/browser/resources/chromeos/chromevox/tools/jsbundler.py:221: dest_dir:
Prepended to each path mentioned in the output, if aplicable.
aplicable -> applicable

[Peter Lundblad, 2014-05-21 18:11:40]

Thanks, Dominic!

@David: since we're going to build on some if this for cvox2, would you
like to take a look as well?

dmazzoni@chromium.org writes:
> lgtm
> 
> 
> 
> 
>
https://codereview.chromium.org/299703003/diff/20001/chrome/browser/resources...
> File chrome/browser/resources/chromeos/chromevox/chromevox.gyp (right):
> 
>
https://codereview.chromium.org/299703003/diff/20001/chrome/browser/resources...
> chrome/browser/resources/chromeos/chromevox/chromevox.gyp:9: # Whether
> to compress the 4 main ChroeVox scripts.  applicable if
> ChroeVox -> ChromeVox, and capitalize "applicable"

Done.

>
https://codereview.chromium.org/299703003/diff/20001/chrome/browser/resources...
> File chrome/browser/resources/chromeos/chromevox/tools/jsbundler.py
> (right):
> 
>
https://codereview.chromium.org/299703003/diff/20001/chrome/browser/resources...
> chrome/browser/resources/chromeos/chromevox/tools/jsbundler.py:21: -
> bundle: a cocatenation of all the files, separated by newlines.
> cocatenation -> concatenation

Done.

>
https://codereview.chromium.org/299703003/diff/20001/chrome/browser/resources...
> chrome/browser/resources/chromeos/chromevox/tools/jsbundler.py:193:
> '''Copies a list of sources to a destination directory.'''
> I think this function should be called HardLinkOrCopyFiles and the
> helper should be LinkOrCopyOneFile

Renamed to be clearer.  I also updated __doc__ to mention this feature...

>
https://codereview.chromium.org/299703003/diff/20001/chrome/browser/resources...
> chrome/browser/resources/chromeos/chromevox/tools/jsbundler.py:221:
> dest_dir: Prepended to each path mentioned in the output, if aplicable.
> aplicable -> applicable

Done.

> https://codereview.chromium.org/299703003/

-- 

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[David Tseng, 2014-05-21 20:42:11]

Looking now; thanks!


On Wed, May 21, 2014 at 11:11 AM, <plundblad@chromium.org> wrote:

> Thanks, Dominic!
>
> @David: since we're going to build on some if this for cvox2, would you
> like to take a look as well?
>
> dmazzoni@chromium.org writes:
> > lgtm
> >
> >
> >
> >
> >
>
https://codereview.chromium.org/299703003/diff/20001/chrome/browser/resources...
> > File chrome/browser/resources/chromeos/chromevox/chromevox.gyp (right):
> >
> >
>
https://codereview.chromium.org/299703003/diff/20001/chrome/browser/resources...
> > chrome/browser/resources/chromeos/chromevox/chromevox.gyp:9: # Whether
> > to compress the 4 main ChroeVox scripts.  applicable if
> > ChroeVox -> ChromeVox, and capitalize "applicable"
>
> Done.
>
> >
>
https://codereview.chromium.org/299703003/diff/20001/chrome/browser/resources...
> > File chrome/browser/resources/chromeos/chromevox/tools/jsbundler.py
> > (right):
> >
> >
>
https://codereview.chromium.org/299703003/diff/20001/chrome/browser/resources...
> > chrome/browser/resources/chromeos/chromevox/tools/jsbundler.py:21: -
> > bundle: a cocatenation of all the files, separated by newlines.
> > cocatenation -> concatenation
>
> Done.
>
> >
>
https://codereview.chromium.org/299703003/diff/20001/chrome/browser/resources...
> > chrome/browser/resources/chromeos/chromevox/tools/jsbundler.py:193:
> > '''Copies a list of sources to a destination directory.'''
> > I think this function should be called HardLinkOrCopyFiles and the
> > helper should be LinkOrCopyOneFile
>
> Renamed to be clearer.  I also updated __doc__ to mention this feature...
>
> >
>
https://codereview.chromium.org/299703003/diff/20001/chrome/browser/resources...
> > chrome/browser/resources/chromeos/chromevox/tools/jsbundler.py:221:
> > dest_dir: Prepended to each path mentioned in the output, if aplicable.
> > aplicable -> applicable
>
> Done.
>
> > https://codereview.chromium.org/299703003/
>
> --
>
> To unsubscribe from this group and stop receiving emails from it, send an
> email to chromium-reviews+unsubscribe@chromium.org.
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[David Tseng, 2014-05-21 21:08:49]

lgtm

Are you planning to generate the html files containing the enumerated script
deps in a followup cl?

https://codereview.chromium.org/299703003/diff/40001/chrome/browser/resources...
File
chrome/browser/resources/chromeos/chromevox/chromevox/background/kbexplorer_loader.js
(right):

https://codereview.chromium.org/299703003/diff/40001/chrome/browser/resources...
chrome/browser/resources/chromeos/chromevox/chromevox/background/kbexplorer_loader.js:6:
* @fileoverview Description of this file.
Fix this.

https://codereview.chromium.org/299703003/diff/40001/chrome/browser/resources...
File chrome/browser/resources/chromeos/chromevox/chromevox/injected/loader.js
(right):

https://codereview.chromium.org/299703003/diff/40001/chrome/browser/resources...
chrome/browser/resources/chromeos/chromevox/chromevox/injected/loader.js:7: *
@fileoverview Defines the ChromeVox app.
nit: Loads the ChromeVox content script.

https://codereview.chromium.org/299703003/diff/40001/chrome/browser/resources...
File chrome/browser/resources/chromeos/chromevox/compress_js.gypi (right):

https://codereview.chromium.org/299703003/diff/40001/chrome/browser/resources...
chrome/browser/resources/chromeos/chromevox/compress_js.gypi:35:
'tools/jsbundler.py',
Maybe this gypi file belongs alongside this python script.

[Peter Lundblad, 2014-05-21 22:37:06]

dtseng@chromium.org writes:
> lgtm
> 
> Are you planning to generate the html files containing the enumerated script
> deps in a followup cl?

The python script already has the ability to do this for a given set of
top-level files, the only thing that's missing is a .gypi that looks very
similar to the compress_js.gypi, but it would have a different mode and take
path rewrite
rules.  We should add that when we need it and if not before, I will do that
when
hooking up the uncompiled background page.


>
https://codereview.chromium.org/299703003/diff/40001/chrome/browser/resources...
> File
>
chrome/browser/resources/chromeos/chromevox/chromevox/background/kbexplorer_loader.js
> (right):
> 
>
https://codereview.chromium.org/299703003/diff/40001/chrome/browser/resources...
>
chrome/browser/resources/chromeos/chromevox/chromevox/background/kbexplorer_loader.js:6:
> * @fileoverview Description of this file.
> Fix this.

In general I haven't fixed javadoc when copying files from google3.  Since the
uncompiled tree are slightly out of date, we'll need to push those again, so I
suggest that if we want to fix this, we fix it in google3 to keep things
simple.

>
https://codereview.chromium.org/299703003/diff/40001/chrome/browser/resources...
> File
> chrome/browser/resources/chromeos/chromevox/chromevox/injected/loader.js
> (right):
> 
>
https://codereview.chromium.org/299703003/diff/40001/chrome/browser/resources...
> chrome/browser/resources/chromeos/chromevox/chromevox/injected/loader.js:7:
> * @fileoverview Defines the ChromeVox app.
> nit: Loads the ChromeVox content script.

No nit-picking in copied files, please;)

>
https://codereview.chromium.org/299703003/diff/40001/chrome/browser/resources...
> File chrome/browser/resources/chromeos/chromevox/compress_js.gypi
> (right):
> 
>
https://codereview.chromium.org/299703003/diff/40001/chrome/browser/resources...
> chrome/browser/resources/chromeos/chromevox/compress_js.gypi:35:
> 'tools/jsbundler.py',
> Maybe this gypi file belongs alongside this python script.

Not sure, I see examples of both in the tree. There's some benefit from having
them
next to the gyp file.  I am happy to move in a follow-up cl if you feel
strongly.

> https://codereview.chromium.org/299703003/

-- 

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Peter Lundblad, 2014-05-21 22:37:31]

The CQ bit was checked by plundblad@chromium.org

[commit-bot: I haz the power, 2014-05-21 22:39:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/plundblad@chromium.org/299703003/40001

[commit-bot: I haz the power, 2014-05-22 06:28:11]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-22 08:52:09]

Change committed as 272146