Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1037)

Unified Diff: chrome/third_party/chromevox/chromevox.gyp

Issue 299703003: Build ChromeVox using gyp. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Address nits from Dominic. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/third_party/chromevox/chromevox.gyp
diff --git a/chrome/third_party/chromevox/chromevox.gyp b/chrome/third_party/chromevox/chromevox.gyp
index 9c2c1731f73f683b7f06fd9b0534f70887616486..83ecc4f3b63899da1f426d1431500ba4bdbfae66 100644
--- a/chrome/third_party/chromevox/chromevox.gyp
+++ b/chrome/third_party/chromevox/chromevox.gyp
@@ -10,15 +10,6 @@
'target_name': 'chromevox_third_party_resources',
'type': 'none',
'copies': [
- {
- 'destination': '<(PRODUCT_DIR)/resources/chromeos/chromevox',
- 'files': [
- 'chromeVoxChromeBackgroundScript.js',
- 'chromeVoxChromeOptionsScript.js',
- 'chromeVoxChromePageScript.js',
- 'chromeVoxKbExplorerScript.js',
- ],
- },
# TODO(plundblad): Some of these css files are forks of
# cs from Chrome's web ui. Consider consolidating those.
{
@@ -37,18 +28,27 @@
],
},
{
- 'destination': '<(PRODUCT_DIR)/resources/chromeos/chromevox/closure',
- 'files': [
- 'third_party/closure-library/closure/goog/base.js',
- ],
- },
- {
'destination': '<(PRODUCT_DIR)/resources/chromeos/chromevox/',
'files': [
'_locales/',
],
},
],
+ 'conditions': [
+ ['use_migrated_chromevox==0', {
+ 'copies': [
+ {
+ 'destination': '<(PRODUCT_DIR)/resources/chromeos/chromevox',
+ 'files': [
+ 'chromeVoxChromeBackgroundScript.js',
+ 'chromeVoxChromeOptionsScript.js',
+ 'chromeVoxChromePageScript.js',
+ 'chromeVoxKbExplorerScript.js',
+ ],
+ },
+ ],
+ }],
+ ],
},
],
}],

Powered by Google App Engine
This is Rietveld 408576698