Refactor of the GetEmbedderInformation APIs

Refactor of the GetEmbedderInformation APIs

The embedder can rely on embedded_dart_io to partially fill the
Dart_EmbedderInformation structure with all the process related
information.

R=zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/491390eeaa7974f44a8931d10a899c39c0df8dda

[zra, 2017-08-16 16:13:52]

https://codereview.chromium.org/2997013002/diff/1/runtime/bin/embedded_dart_io.h
File runtime/bin/embedded_dart_io.h (right):

https://codereview.chromium.org/2997013002/diff/1/runtime/bin/embedded_dart_i...
runtime/bin/embedded_dart_io.h:38: // Partial implementation of a
Dart_EmbedderInformationCallback that fills the
This might be extended in the future, so maybe:

"Set dart:io implementation specific fields of Dart_EmbedderInformation"

https://codereview.chromium.org/2997013002/diff/1/runtime/bin/process.cc
File runtime/bin/process.cc (right):

https://codereview.chromium.org/2997013002/diff/1/runtime/bin/process.cc#newc...
runtime/bin/process.cc:372: void Process::GetRSSInformation(uintptr_t* max,
uintptr_t* current) {
max and current should be int64_t. The types of the fields in Dart_EmbedderInfo
should also be int64_t rather than uintptr_t. Service{Max,Current}RSS() take the
fields and return int64_t so we should avoid going back and forth.

https://codereview.chromium.org/2997013002/diff/1/runtime/bin/process.cc#newc...
runtime/bin/process.cc:373: int64_t max_rss = Process::MaxRSS();
ASSERT((max != NULL) && (current != NULL));

[cbernaschina, 2017-08-16 17:54:54]

https://codereview.chromium.org/2997013002/diff/1/runtime/bin/embedded_dart_io.h
File runtime/bin/embedded_dart_io.h (right):

https://codereview.chromium.org/2997013002/diff/1/runtime/bin/embedded_dart_i...
runtime/bin/embedded_dart_io.h:38: // Partial implementation of a
Dart_EmbedderInformationCallback that fills the
On 2017/08/16 16:13:52, zra wrote:
> This might be extended in the future, so maybe:
> 
> "Set dart:io implementation specific fields of Dart_EmbedderInformation"

Done.

https://codereview.chromium.org/2997013002/diff/1/runtime/bin/process.cc
File runtime/bin/process.cc (right):

https://codereview.chromium.org/2997013002/diff/1/runtime/bin/process.cc#newc...
runtime/bin/process.cc:372: void Process::GetRSSInformation(uintptr_t* max,
uintptr_t* current) {
On 2017/08/16 16:13:52, zra wrote:
> max and current should be int64_t. The types of the fields in
Dart_EmbedderInfo
> should also be int64_t rather than uintptr_t. Service{Max,Current}RSS() take
the
> fields and return int64_t so we should avoid going back and forth. 

Done.

https://codereview.chromium.org/2997013002/diff/1/runtime/bin/process.cc#newc...
runtime/bin/process.cc:373: int64_t max_rss = Process::MaxRSS();
On 2017/08/16 16:13:52, zra wrote:
> ASSERT((max != NULL) && (current != NULL));

Done

To have more precise assertions

ASSERT(max != NULL);
ASSERT(current != NULL);

[zra, 2017-08-16 17:58:44]

lgtm

[cbernaschina, 2017-08-16 17:59:33]

Description was changed from

==========
Refactor of the GetEmbedderInformation APIs

The embedder can rely on embedded_dart_io to partially fill the
Dart_EmbedderInformation structure with all the process related
information.

TBR=zra@google.com
==========

to

==========
Refactor of the GetEmbedderInformation APIs

The embedder can rely on embedded_dart_io to partially fill the
Dart_EmbedderInformation structure with all the process related
information.

R=zra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/491390eeaa7974f44a8931d10a899c39c0df8dda
==========

[cbernaschina, 2017-08-16 17:59:36]

Committed patchset #2 (id:20001) manually as
491390eeaa7974f44a8931d10a899c39c0df8dda.