Refactor of the GetEmbedderInformation APIs

runtime/bin/process.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #if !defined(DART_IO_DISABLED)
 
 #include "bin/process.h"
 
 #include "bin/dartutils.h"
 #include "bin/io_buffer.h"
@@ skipping 351 matching lines @@
 
 void FUNCTION_NAME(ProcessInfo_MaxRSS)(Dart_NativeArguments args) {
   int64_t max_rss = Process::MaxRSS();
   if (max_rss < 0) {
     Dart_SetReturnValue(args, DartUtils::NewDartOSError());
     return;
   }
   Dart_SetIntegerReturnValue(args, max_rss);
 }
 
+void Process::GetRSSInformation(uintptr_t* max, uintptr_t* current) {

[zra, 2017/08/16 16:13:52]

max and current should be int64_t. The types of the fields in Dart_EmbedderInfo
should also be int64_t rather than uintptr_t. Service{Max,Current}RSS() take the
fields and return int64_t so we should avoid going back and forth. 

[cbernaschina, 2017/08/16 17:54:54]

Done.

+  int64_t max_rss = Process::MaxRSS();

[zra, 2017/08/16 16:13:52]

ASSERT((max != NULL) && (current != NULL));

[cbernaschina, 2017/08/16 17:54:54]

Done

To have more precise assertions

ASSERT(max != NULL);
ASSERT(current != NULL);

+  int64_t current_rss = Process::CurrentRSS();
+
+  *max = max_rss >= 0 ? max_rss : 0;
+  *current = current_rss >= 0 ? current_rss : 0;
+}
+
 }  // namespace bin
 }  // namespace dart
 
 #endif  // !defined(DART_IO_DISABLED)