Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 2996833002: Patch to add some dynamic behavior. For the previous change, see (Closed)

Created:
3 years, 4 months ago by mkroghj
Modified:
3 years, 4 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Remove entry for the _static test in the status file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -33 lines) Patch
D tests/language_2/closure_in_initializer_static_test.dart View 1 chunk +0 lines, -31 lines 0 comments Download
M tests/language_2/closure_in_initializer_test.dart View 2 chunks +3 lines, -1 line 0 comments Download
M tests/language_2/language_2.status View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
mkroghj
PTAL
3 years, 4 months ago (2017-08-10 14:30:15 UTC) #3
mkroghj
PTAL
3 years, 4 months ago (2017-08-10 14:39:20 UTC) #5
Bill Hesse
lgtm
3 years, 4 months ago (2017-08-10 14:39:59 UTC) #6
mkroghj
3 years, 4 months ago (2017-08-10 14:49:24 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
ff19f703e06dcc47647fe94ae555360d074e3c5a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698