Migrating a block of dart 1 tests to dart 2

Migrating a block of dart 2:

./language[_strong]/class_keyword_test.dart
./language[_strong]/closure_shared_state_test.dart

R=johnniwinther@google.com

NOTE: I had to bypass hooks since the analyser fails on the files that have static compile-time errors. Should I do something else?
Committed: https://github.com/dart-lang/sdk/commit/fa59030f18c5015f7e25832d9247cc2967e99aa1
Reverted: https://github.com/dart-lang/sdk/commit/f0e8bb629b9c9a0c7028d116f1642a71847175ec
Committed: https://github.com/dart-lang/sdk/commit/3803057169bf37cd01035734a04a64863a5050f1

[mkroghj, 2017-08-10 08:34:06]

Description was changed from

==========
Block of dart 2.0 tests
==========

to

==========
Migrating a block of dart 2:

./language[_strong]/class_keyword_test.dart
./language[_strong]/closure_shared_state_test.dart
==========

[mkroghj, 2017-08-10 08:34:07]

mkroghj@google.com changed reviewers:
+ johnniwinther@google.com, sortie@google.com, whesse@google.com

[mkroghj, 2017-08-10 08:43:32]

Description was changed from

==========
Migrating a block of dart 2:

./language[_strong]/class_keyword_test.dart
./language[_strong]/closure_shared_state_test.dart
==========

to

==========
Migrating a block of dart 2:

./language[_strong]/class_keyword_test.dart
./language[_strong]/closure_shared_state_test.dart

NOTE: I had to bypass hooks since the analyser fails on the files that have
static compile-time errors. Should I do something else?
==========

[mkroghj, 2017-08-10 11:43:01]

PTAL

Regarding the class_literal_test, the instance x was never really used,
therefore I completely in what was previous type warnings, therefore I
completely separated the test into two files:

1) The one that actually tests correct behavior (same name)
2) The one that should give compile-time errors (_static_test)

[Johnni Winther, 2017-08-10 11:50:41]

lgtm

https://codereview.chromium.org/3001433002/diff/20001/tests/language_2/class_...
File tests/language_2/class_literal_test.dart (right):

https://codereview.chromium.org/3001433002/diff/20001/tests/language_2/class_...
tests/language_2/class_literal_test.dart:26: Expect.throws(() { Class(); }, (e)
=> e is NoSuchMethodError); //# 01: compile-time error
Replace this with 

  Expect.throws(() { x(); }, (e) => e is NoSuchMethodError);

and similarly for all deleted lines below to ensure that still test the runtime
behavior of dereferencing a class literal.

[mkroghj, 2017-08-10 12:43:37]

Description was changed from

==========
Migrating a block of dart 2:

./language[_strong]/class_keyword_test.dart
./language[_strong]/closure_shared_state_test.dart

NOTE: I had to bypass hooks since the analyser fails on the files that have
static compile-time errors. Should I do something else?
==========

to

==========
Migrating a block of dart 2:

./language[_strong]/class_keyword_test.dart
./language[_strong]/closure_shared_state_test.dart

R=johnniwinther@google.com

NOTE: I had to bypass hooks since the analyser fails on the files that have
static compile-time errors. Should I do something else?
Committed:
https://github.com/dart-lang/sdk/commit/fa59030f18c5015f7e25832d9247cc2967e99aa1
==========

[mkroghj, 2017-08-10 12:43:38]

Committed patchset #4 (id:60001) manually as
fa59030f18c5015f7e25832d9247cc2967e99aa1.

[mkroghj, 2017-08-10 13:11:42]

Description was changed from

==========
Migrating a block of dart 2:

./language[_strong]/class_keyword_test.dart
./language[_strong]/closure_shared_state_test.dart

R=johnniwinther@google.com

NOTE: I had to bypass hooks since the analyser fails on the files that have
static compile-time errors. Should I do something else?
Committed:
https://github.com/dart-lang/sdk/commit/fa59030f18c5015f7e25832d9247cc2967e99aa1
==========

to

==========
Migrating a block of dart 2:

./language[_strong]/class_keyword_test.dart
./language[_strong]/closure_shared_state_test.dart

R=johnniwinther@google.com

NOTE: I had to bypass hooks since the analyser fails on the files that have
static compile-time errors. Should I do something else?
Committed:
https://github.com/dart-lang/sdk/commit/fa59030f18c5015f7e25832d9247cc2967e99aa1
Committed:
https://github.com/dart-lang/sdk/commit/3803057169bf37cd01035734a04a64863a5050f1
==========

[mkroghj, 2017-08-10 13:11:43]

Committed patchset #5 (id:80001) manually as
3803057169bf37cd01035734a04a64863a5050f1.

[mkroghj, 2017-08-11 07:49:31]

Description was changed from

==========
Migrating a block of dart 2:

./language[_strong]/class_keyword_test.dart
./language[_strong]/closure_shared_state_test.dart

R=johnniwinther@google.com

NOTE: I had to bypass hooks since the analyser fails on the files that have
static compile-time errors. Should I do something else?
Committed:
https://github.com/dart-lang/sdk/commit/fa59030f18c5015f7e25832d9247cc2967e99aa1
Committed:
https://github.com/dart-lang/sdk/commit/3803057169bf37cd01035734a04a64863a5050f1
==========

to

==========
Migrating a block of dart 2:

./language[_strong]/class_keyword_test.dart
./language[_strong]/closure_shared_state_test.dart

R=johnniwinther@google.com

NOTE: I had to bypass hooks since the analyser fails on the files that have
static compile-time errors. Should I do something else?
Committed:
https://github.com/dart-lang/sdk/commit/fa59030f18c5015f7e25832d9247cc2967e99aa1
Reverted:
https://github.com/dart-lang/sdk/commit/f0e8bb629b9c9a0c7028d116f1642a71847175ec
Committed:
https://github.com/dart-lang/sdk/commit/3803057169bf37cd01035734a04a64863a5050f1
==========