Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2996693002: iSAC fixed-point implementation of the Audio{En,De}coderFactoryTemplate APIs (Closed)

Created:
3 years, 4 months ago by kwiberg-webrtc
Modified:
3 years, 4 months ago
Reviewers:
ossu
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com, kwiberg-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

iSAC fixed-point implementation of the Audio{En,De}coderFactoryTemplate APIs BUG=webrtc:7835, webrtc:7841 Review-Url: https://codereview.webrtc.org/2996693002 Cr-Commit-Position: refs/heads/master@{#19409} Committed: https://chromium.googlesource.com/external/webrtc/+/327af331515570a44f30a1f6ea102c65029a7719

Patch Set 1 #

Patch Set 2 : bitrate is variable #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Patch Set 5 : review comments #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+251 lines, -0 lines) Patch
A webrtc/api/audio_codecs/isac/BUILD.gn View 1 chunk +39 lines, -0 lines 0 comments Download
A webrtc/api/audio_codecs/isac/audio_decoder_isac_fix.h View 1 2 3 4 1 chunk +36 lines, -0 lines 0 comments Download
A webrtc/api/audio_codecs/isac/audio_decoder_isac_fix.cc View 1 1 chunk +37 lines, -0 lines 0 comments Download
A webrtc/api/audio_codecs/isac/audio_encoder_isac_fix.h View 1 2 3 4 1 chunk +41 lines, -0 lines 0 comments Download
A webrtc/api/audio_codecs/isac/audio_encoder_isac_fix.cc View 1 2 3 4 1 chunk +61 lines, -0 lines 2 comments Download
M webrtc/api/audio_codecs/test/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/api/audio_codecs/test/audio_decoder_factory_template_unittest.cc View 1 2 3 2 chunks +14 lines, -0 lines 0 comments Download
M webrtc/api/audio_codecs/test/audio_encoder_factory_template_unittest.cc View 1 2 3 4 2 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 27 (20 generated)
kwiberg-webrtc
3 years, 4 months ago (2017-08-08 22:24:50 UTC) #4
kwiberg-webrtc
Uploaded a new patch set, where I've fixed all the things you pointed out in ...
3 years, 4 months ago (2017-08-17 13:33:54 UTC) #17
ossu
https://codereview.webrtc.org/2996693002/diff/80001/webrtc/api/audio_codecs/isac/audio_encoder_isac_fix.cc File webrtc/api/audio_codecs/isac/audio_encoder_isac_fix.cc (right): https://codereview.webrtc.org/2996693002/diff/80001/webrtc/api/audio_codecs/isac/audio_encoder_isac_fix.cc#newcode22 webrtc/api/audio_codecs/isac/audio_encoder_isac_fix.cc:22: if (STR_CASE_CMP(format.name.c_str(), "ISAC") == 0 && Does this mean ...
3 years, 4 months ago (2017-08-18 10:20:00 UTC) #20
kwiberg-webrtc
https://codereview.webrtc.org/2996693002/diff/80001/webrtc/api/audio_codecs/isac/audio_encoder_isac_fix.cc File webrtc/api/audio_codecs/isac/audio_encoder_isac_fix.cc (right): https://codereview.webrtc.org/2996693002/diff/80001/webrtc/api/audio_codecs/isac/audio_encoder_isac_fix.cc#newcode22 webrtc/api/audio_codecs/isac/audio_encoder_isac_fix.cc:22: if (STR_CASE_CMP(format.name.c_str(), "ISAC") == 0 && On 2017/08/18 10:19:59, ...
3 years, 4 months ago (2017-08-18 10:47:21 UTC) #21
ossu
lgtm then! :)
3 years, 4 months ago (2017-08-18 11:03:17 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2996693002/80001
3 years, 4 months ago (2017-08-18 11:07:07 UTC) #24
commit-bot: I haz the power
3 years, 4 months ago (2017-08-18 11:09:46 UTC) #27
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/external/webrtc/+/327af331515570a44f30a1f6e...

Powered by Google App Engine
This is Rietveld 408576698