Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 299653002: Reland "Simplify debugger state." (Closed)

Created:
6 years, 7 months ago by Yang
Modified:
6 years, 7 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Reland "Simplify debugger state." R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21378

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : fix test to check for pointer equality instead of handle equality #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -210 lines) Patch
M src/bootstrapper.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M src/d8.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/debug.h View 7 chunks +35 lines, -56 lines 0 comments Download
M src/debug.cc View 1 2 14 chunks +54 lines, -119 lines 0 comments Download
M src/execution.cc View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M src/isolate.cc View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M src/runtime.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M test/cctest/test-debug.cc View 1 2 5 chunks +15 lines, -18 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/debug-stepin-positions.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
second patch set fixes the issue.
6 years, 7 months ago (2014-05-20 08:06:18 UTC) #1
ulan
lgtm
6 years, 7 months ago (2014-05-20 08:08:57 UTC) #2
Yang
6 years, 7 months ago (2014-05-20 08:52:52 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r21378 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698