src/d8.cc - Issue 299653002: Reland "Simplify debugger state."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/d8.cc

Issue 299653002: Reland "Simplify debugger state." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: fix test to check for pointer equality instead of handle equality Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/d8.cc

diff --git a/src/d8.cc b/src/d8.cc

index 502187a9a70d9d9437689d4c98df7104910a3666..a467333060ee6635e5cce1aac7b83d6474a72afa 100644

--- a/src/d8.cc

+++ b/src/d8.cc

@@ -753,11 +753,12 @@ void Shell::InstallUtilityScript(Isolate* isolate) {

// Install the debugger object in the utility scope

i::Debug* debug = reinterpret_cast<i::Isolate*>(isolate)->debug();

debug->Load();

+ i::Handle<i::Context> debug_context = debug->debug_context();

i::Handle<i::JSObject> js_debug

- = i::Handle<i::JSObject>(debug->debug_context()->global_object());

+ = i::Handle<i::JSObject>(debug_context->global_object());

utility_context->Global()->Set(String::NewFromUtf8(isolate, "$debug"),

Utils::ToLocal(js_debug));

- debug->debug_context()->set_security_token(

+ debug_context->set_security_token(

reinterpret_cast<i::Isolate*>(isolate)->heap()->undefined_value());

// Run the d8 shell utility script in the utility context

« no previous file with comments | « src/bootstrapper.cc ('k') | src/debug.h » ('j') | no next file with comments »