Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 2996253002: VideoProcessor: make it runnable on a task queue. (Closed)

Created:
3 years, 4 months ago by brandtr
Modified:
3 years, 4 months ago
Reviewers:
åsapersson
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

VideoProcessor: make it runnable on a task queue. * Guard members with a SequencedTaskChecker. * Intercept encoder/decoder callbacks, and post onto task queue if needed. BUG=webrtc:6634 Review-Url: https://codereview.webrtc.org/2996253002 Cr-Commit-Position: refs/heads/master@{#19428} Committed: https://chromium.googlesource.com/external/webrtc/+/c8c59059b74d6e093dd86902ada98eba587d984a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -16 lines) Patch
M webrtc/modules/video_coding/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor.h View 6 chunks +67 lines, -14 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor.cc View 11 chunks +20 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (8 generated)
brandtr
Split up the mega-CL in several smaller ones, for easier review :) The first three ...
3 years, 4 months ago (2017-08-18 13:57:58 UTC) #2
åsapersson
lgtm
3 years, 4 months ago (2017-08-21 11:39:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2996253002/1
3 years, 4 months ago (2017-08-21 13:41:56 UTC) #9
commit-bot: I haz the power
3 years, 4 months ago (2017-08-21 13:44:24 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/c8c59059b74d6e093dd86902a...

Powered by Google App Engine
This is Rietveld 408576698