Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 2996013002: Fix index bug in readResults (Closed)

Created:
3 years, 4 months ago by Johnni Winther
Modified:
3 years, 4 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -3 lines) Patch
M tools/gardening/lib/src/bot.dart View 3 chunks +4 lines, -2 lines 0 comments Download
M tools/gardening/lib/src/compare_failures_impl.dart View 1 chunk +5 lines, -1 line 0 comments Download
A tools/gardening/test/bot_test.dart View 1 chunk +20 lines, -0 lines 0 comments Download
M tools/gardening/test/test_client.dart View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 4 months ago (2017-08-16 08:10:08 UTC) #2
floitsch
oops. LGTM.
3 years, 4 months ago (2017-08-16 11:37:53 UTC) #3
Johnni Winther
3 years, 4 months ago (2017-08-16 12:28:48 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9abec74aaff75c5b23db1daea81e66c69e63c01e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698