Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: tools/gardening/lib/src/compare_failures_impl.dart

Issue 2996013002: Fix index bug in readResults (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gardening/lib/src/bot.dart ('k') | tools/gardening/test/bot_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gardening/lib/src/compare_failures_impl.dart
diff --git a/tools/gardening/lib/src/compare_failures_impl.dart b/tools/gardening/lib/src/compare_failures_impl.dart
index 886d06f1efa84d6882cda50061af6b1457c4aa51..6104fba670f634b52c1e6e94d27d8021301525c0 100644
--- a/tools/gardening/lib/src/compare_failures_impl.dart
+++ b/tools/gardening/lib/src/compare_failures_impl.dart
@@ -37,7 +37,11 @@ Future<Map<BuildUri, List<BuildResult>>> loadBuildResults(
Map<BuildUri, List<BuildResult>> pastResultsMap =
<BuildUri, List<BuildResult>>{};
List<BuildResult> buildResults = await bot.readResults(buildUriList);
- for (int index = 0; index < buildUriList.length; index++) {
+ if (buildResults.length != buildUriList.length) {
+ print('Result mismatch: Pulled ${buildUriList.length} uris, '
+ 'received ${buildResults.length} results.');
+ }
+ for (int index = 0; index < buildResults.length; index++) {
BuildUri buildUri = buildUriList[index];
BuildResult buildResult = buildResults[index];
List<BuildResult> results =
« no previous file with comments | « tools/gardening/lib/src/bot.dart ('k') | tools/gardening/test/bot_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698