Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2995723002: - Convert all isolate flags to a bit field. (Closed)

Created:
3 years, 4 months ago by siva
Modified:
3 years, 4 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, turnidge, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

- Convert all isolate flags to a bit field. - Add a new isolate specific flag to cause the isolate to run in kernel mode. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/73d30074b126d45cc32686ceb9a7efe603339345

Patch Set 1 #

Patch Set 2 : Fix errors reported by tests. #

Patch Set 3 : fix prouct build. #

Total comments: 2

Patch Set 4 : Address code review comments. #

Patch Set 5 : Address code review comments. #

Patch Set 6 : Address build error. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+202 lines, -116 lines) Patch
M runtime/bin/gen_snapshot.cc View 2 chunks +2 lines, -1 line 0 comments Download
M runtime/bin/main.cc View 2 chunks +5 lines, -1 line 0 comments Download
M runtime/bin/run_vm_tests.cc View 3 chunks +4 lines, -1 line 0 comments Download
M runtime/include/dart_api.h View 4 chunks +4 lines, -2 lines 0 comments Download
M runtime/vm/benchmark_test.cc View 1 2 chunks +6 lines, -1 line 0 comments Download
M runtime/vm/dart.h View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/dart.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 5 chunks +11 lines, -8 lines 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 3 chunks +9 lines, -2 lines 0 comments Download
M runtime/vm/debugger.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/isolate.h View 1 2 3 4 12 chunks +122 lines, -50 lines 0 comments Download
M runtime/vm/isolate.cc View 1 2 3 4 5 7 chunks +19 lines, -21 lines 0 comments Download
M runtime/vm/kernel_isolate.cc View 5 chunks +1 line, -20 lines 0 comments Download
M runtime/vm/service_isolate.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/unit_test.cc View 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
siva
3 years, 4 months ago (2017-08-10 22:58:38 UTC) #2
rmacnak
lgtm w/c https://codereview.chromium.org/2995723002/diff/20002/runtime/vm/isolate.h File runtime/vm/isolate.h (right): https://codereview.chromium.org/2995723002/diff/20002/runtime/vm/isolate.h#newcode899 runtime/vm/isolate.h:899: bool single_step_; single_step_ is accessed from generated ...
3 years, 4 months ago (2017-08-11 00:11:34 UTC) #3
siva
reordered fields to address comment. PTAL. https://codereview.chromium.org/2995723002/diff/20002/runtime/vm/isolate.h File runtime/vm/isolate.h (right): https://codereview.chromium.org/2995723002/diff/20002/runtime/vm/isolate.h#newcode899 runtime/vm/isolate.h:899: bool single_step_; On ...
3 years, 4 months ago (2017-08-11 01:08:59 UTC) #4
rmacnak
On 2017/08/11 01:08:59, siva wrote: > reordered fields to address comment. > > PTAL. > ...
3 years, 4 months ago (2017-08-11 17:17:14 UTC) #5
siva
PTAL
3 years, 4 months ago (2017-08-11 17:37:35 UTC) #6
siva
3 years, 4 months ago (2017-08-11 17:53:28 UTC) #7
rmacnak
lgtm
3 years, 4 months ago (2017-08-11 18:01:17 UTC) #8
siva
3 years, 4 months ago (2017-08-11 19:38:30 UTC) #10
Message was sent while issue was closed. 
Committed patchset #6 (id:90001) manually as
73d30074b126d45cc32686ceb9a7efe603339345 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698