Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Unified Diff: runtime/vm/dart_api_impl_test.cc

Issue 2995723002: - Convert all isolate flags to a bit field. (Closed)
Patch Set: Address build error. Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/dart_api_impl.cc ('k') | runtime/vm/debugger.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dart_api_impl_test.cc
diff --git a/runtime/vm/dart_api_impl_test.cc b/runtime/vm/dart_api_impl_test.cc
index d2ee3b21fd9061be74c528a6891ad0e75ea64801..3ba81989dbc385e1e39c6242d68f191452d0a2d7 100644
--- a/runtime/vm/dart_api_impl_test.cc
+++ b/runtime/vm/dart_api_impl_test.cc
@@ -3471,6 +3471,7 @@ VM_UNIT_TEST_CASE(IsolateSetCheckedMode) {
api_flags.enable_asserts = true;
api_flags.enable_error_on_bad_type = true;
api_flags.enable_error_on_bad_override = true;
+ api_flags.use_dart_frontend = FLAG_use_dart_frontend;
char* err;
Dart_Isolate isolate = Dart_CreateIsolate(
@@ -7408,9 +7409,12 @@ void BusyLoop_start(uword unused) {
{
MonitorLocker ml(sync);
char* error = NULL;
+ Dart_IsolateFlags api_flags;
+ Isolate::FlagsInitialize(&api_flags);
+ api_flags.use_dart_frontend = FLAG_use_dart_frontend;
shared_isolate = Dart_CreateIsolate(
NULL, NULL, bin::core_isolate_snapshot_data,
- bin::core_isolate_snapshot_instructions, NULL, NULL, &error);
+ bin::core_isolate_snapshot_instructions, &api_flags, NULL, &error);
EXPECT(shared_isolate != NULL);
Dart_EnterScope();
Dart_Handle url = NewString(TestCase::url());
@@ -7509,9 +7513,12 @@ VM_UNIT_TEST_CASE(IsolateShutdownRunDartCode) {
// Create an isolate.
char* err;
+ Dart_IsolateFlags api_flags;
+ Isolate::FlagsInitialize(&api_flags);
+ api_flags.use_dart_frontend = FLAG_use_dart_frontend;
Dart_Isolate isolate = Dart_CreateIsolate(
NULL, NULL, bin::core_isolate_snapshot_data,
- bin::core_isolate_snapshot_instructions, NULL, NULL, &err);
+ bin::core_isolate_snapshot_instructions, &api_flags, NULL, &err);
if (isolate == NULL) {
OS::Print("Creation of isolate failed '%s'\n", err);
free(err);
« no previous file with comments | « runtime/vm/dart_api_impl.cc ('k') | runtime/vm/debugger.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698