Add GetSharedPrefs to Android platform

Add GetSharedPrefs to Android platform

Adds a GetSharedPrefs method to AndroidPlatform and
AndroidPlatformBackend. All this does is return a SharedPrefs instance
for the backend's DeviceUtils member so that test code can change app
settings withing needing to expose the DeviceUtils itself.

This is a prerequisite CL for submitting https://chromium-review.googlesource.com/608984

BUG=chromium:726906
Review-Url: https://codereview.chromium.org/2995713002
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/af523a1723e562e65becbc4fd7281445af79eb75

[bsheedy, 2017-08-09 23:30:04]

Description was changed from

==========
Add GetSharedPrefs to Android platform

Adds a GetSharedPrefs method to AndroidPlatform and
AndroidPlatformBackend. All this does is return a SharedPrefs instance
for the backend's DeviceUtils member so that test code can change app
settings withing needing to expose the DeviceUtils itself.

BUG=chromium:#726906
==========

to

==========
Add GetSharedPrefs to Android platform

Adds a GetSharedPrefs method to AndroidPlatform and
AndroidPlatformBackend. All this does is return a SharedPrefs instance
for the backend's DeviceUtils member so that test code can change app
settings withing needing to expose the DeviceUtils itself.

BUG=726906
==========

[bsheedy, 2017-08-10 00:21:05]

Description was changed from

==========
Add GetSharedPrefs to Android platform

Adds a GetSharedPrefs method to AndroidPlatform and
AndroidPlatformBackend. All this does is return a SharedPrefs instance
for the backend's DeviceUtils member so that test code can change app
settings withing needing to expose the DeviceUtils itself.

BUG=726906
==========

to

==========
Add GetSharedPrefs to Android platform

Adds a GetSharedPrefs method to AndroidPlatform and
AndroidPlatformBackend. All this does is return a SharedPrefs instance
for the backend's DeviceUtils member so that test code can change app
settings withing needing to expose the DeviceUtils itself.

This is a prerequisite CL for submitting
https://chromium-review.googlesource.com/608984

BUG=726906
==========

[bsheedy, 2017-08-10 00:22:25]

bsheedy@chromium.org changed reviewers:
+ nednguyen@google.com

[bsheedy, 2017-08-10 00:22:26]

PTAL

[nednguyen, 2017-08-10 00:28:54]

https://codereview.chromium.org/2995713002/diff/1/telemetry/telemetry/core/an...
File telemetry/telemetry/core/android_platform.py (right):

https://codereview.chromium.org/2995713002/diff/1/telemetry/telemetry/core/an...
telemetry/telemetry/core/android_platform.py:33: def GetSharedPrefs(self,
package, filename):
Can you document this methods following the style guide:
https://google.github.io/styleguide/pyguide.html#Comments

[bsheedy, 2017-08-10 00:44:49]

Description was changed from

==========
Add GetSharedPrefs to Android platform

Adds a GetSharedPrefs method to AndroidPlatform and
AndroidPlatformBackend. All this does is return a SharedPrefs instance
for the backend's DeviceUtils member so that test code can change app
settings withing needing to expose the DeviceUtils itself.

This is a prerequisite CL for submitting
https://chromium-review.googlesource.com/608984

BUG=726906
==========

to

==========
Add GetSharedPrefs to Android platform

Adds a GetSharedPrefs method to AndroidPlatform and
AndroidPlatformBackend. All this does is return a SharedPrefs instance
for the backend's DeviceUtils member so that test code can change app
settings withing needing to expose the DeviceUtils itself.

This is a prerequisite CL for submitting
https://chromium-review.googlesource.com/608984

BUG=chromium:726906
==========

[bsheedy, 2017-08-10 00:45:51]

https://codereview.chromium.org/2995713002/diff/1/telemetry/telemetry/core/an...
File telemetry/telemetry/core/android_platform.py (right):

https://codereview.chromium.org/2995713002/diff/1/telemetry/telemetry/core/an...
telemetry/telemetry/core/android_platform.py:33: def GetSharedPrefs(self,
package, filename):
On 2017/08/10 00:28:54, nednguyen wrote:
> Can you document this methods following the style guide:
> https://google.github.io/styleguide/pyguide.html#Comments

Done.

[nednguyen, 2017-08-10 00:49:34]

lgtm

https://codereview.chromium.org/2995713002/diff/20001/telemetry/telemetry/cor...
File telemetry/telemetry/core/android_platform.py (right):

https://codereview.chromium.org/2995713002/diff/20001/telemetry/telemetry/cor...
telemetry/telemetry/core/android_platform.py:47: on whatever device the platform
backend has a reference to.
nits: on whatever device this platform object refers to.

[bsheedy, 2017-08-10 00:51:41]

The CQ bit was checked by bsheedy@chromium.org

[bsheedy, 2017-08-10 00:51:42]

The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com
Link to the patchset: https://codereview.chromium.org/2995713002/#ps40001
(title: "Address nit")

[commit-bot: I haz the power, 2017-08-10 00:51:54]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-08-10 01:18:45]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1502326301955120,
"parent_rev": "bd05965e45572ae06d1a7139759a85a3d9a1a27c", "commit_rev":
"af523a1723e562e65becbc4fd7281445af79eb75"}

[commit-bot: I haz the power, 2017-08-10 01:18:49]

Description was changed from

==========
Add GetSharedPrefs to Android platform

Adds a GetSharedPrefs method to AndroidPlatform and
AndroidPlatformBackend. All this does is return a SharedPrefs instance
for the backend's DeviceUtils member so that test code can change app
settings withing needing to expose the DeviceUtils itself.

This is a prerequisite CL for submitting
https://chromium-review.googlesource.com/608984

BUG=chromium:726906
==========

to

==========
Add GetSharedPrefs to Android platform

Adds a GetSharedPrefs method to AndroidPlatform and
AndroidPlatformBackend. All this does is return a SharedPrefs instance
for the backend's DeviceUtils member so that test code can change app
settings withing needing to expose the DeviceUtils itself.

This is a prerequisite CL for submitting
https://chromium-review.googlesource.com/608984

BUG=chromium:726906

Review-Url: https://codereview.chromium.org/2995713002
Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2017-08-10 01:18:50]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...