Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1307)

Unified Diff: runtime/vm/isolate.h

Issue 2995543004: [vm, gc] Require a safepoint for heap iteration. (Closed)
Patch Set: . Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/isolate.h
diff --git a/runtime/vm/isolate.h b/runtime/vm/isolate.h
index 62572410ee3a6bd156e7fd0fd7705c346fbb7e55..fea025f5bf56228017711d1fa195e5b1c3069ba8 100644
--- a/runtime/vm/isolate.h
+++ b/runtime/vm/isolate.h
@@ -178,12 +178,6 @@ class Isolate : public BaseIsolate {
void RegisterClassAt(intptr_t index, const Class& cls);
void ValidateClassTable();
- // Visit all object pointers.
- void IterateObjectPointers(ObjectPointerVisitor* visitor,
- bool validate_frames);
- void IterateStackPointers(ObjectPointerVisitor* visitor,
- bool validate_frames);
-
// Visits weak object pointers.
void VisitWeakPersistentHandles(HandleVisitor* visitor);
@@ -929,8 +923,9 @@ class Isolate : public BaseIsolate {
friend class Become; // VisitObjectPointers
friend class GCMarker; // VisitObjectPointers
friend class SafepointHandler;
- friend class Scavenger; // VisitObjectPointers
friend class ObjectGraph; // VisitObjectPointers
+ friend class Scavenger; // VisitObjectPointers
+ friend class HeapIterationScope; // VisitObjectPointers
friend class ServiceIsolate;
friend class Thread;
friend class Timeline;

Powered by Google App Engine
This is Rietveld 408576698