Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2609)

Unified Diff: runtime/vm/isolate.cc

Issue 2995543004: [vm, gc] Require a safepoint for heap iteration. (Closed)
Patch Set: . Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/isolate.cc
diff --git a/runtime/vm/isolate.cc b/runtime/vm/isolate.cc
index 8589373d6fda2de551c70ceb77942a4a4ae4c2b7..b70d994d8d384134db59609177a07abccec5c6bb 100644
--- a/runtime/vm/isolate.cc
+++ b/runtime/vm/isolate.cc
@@ -1465,8 +1465,9 @@ static void ShutdownIsolate(uword parameter) {
// This would otherwise happen in Dart::ShowdownIsolate.
isolate->StopBackgroundCompiler();
isolate->heap()->CollectAllGarbage();
+ HeapIterationScope iteration;
VerifyCanonicalVisitor check_canonical(thread);
- isolate->heap()->IterateObjects(&check_canonical);
+ iteration.IterateObjects(&check_canonical);
}
#endif // DEBUG
const Error& error = Error::Handle(thread->sticky_error());
@@ -1738,18 +1739,6 @@ Monitor* Isolate::isolates_list_monitor_ = NULL;
Isolate* Isolate::isolates_list_head_ = NULL;
bool Isolate::creation_enabled_ = false;
-void Isolate::IterateObjectPointers(ObjectPointerVisitor* visitor,
- bool validate_frames) {
- HeapIterationScope heap_iteration_scope;
- VisitObjectPointers(visitor, validate_frames);
-}
-
-void Isolate::IterateStackPointers(ObjectPointerVisitor* visitor,
- bool validate_frames) {
- HeapIterationScope heap_iteration_scope;
- VisitStackPointers(visitor, validate_frames);
-}
-
void Isolate::VisitObjectPointers(ObjectPointerVisitor* visitor,
bool validate_frames) {
ASSERT(visitor != NULL);

Powered by Google App Engine
This is Rietveld 408576698