[vm] Prevent non-fatal errors from causing timers to be dropped.

[vm] Prevent non-fatal errors from causing timers to be dropped.

Issue #30425

R=zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/8692f618f6a71f3e47f6ecf18ab45a1fb0df696b

[rmacnak, 2017-08-16 21:38:13]

rmacnak@google.com changed reviewers:
+ lrn@chromium.org, zra@google.com

[zra, 2017-08-16 21:46:56]

https://codereview.chromium.org/2995103002/diff/1/runtime/lib/timer_impl.dart
File runtime/lib/timer_impl.dart (right):

https://codereview.chromium.org/2995103002/diff/1/runtime/lib/timer_impl.dart...
runtime/lib/timer_impl.dart:387: _notifyEventHandler();
Would it be okay to only notify the event handler if an event needed to be
requeued, or do you need to do it every time?

[rmacnak, 2017-08-16 21:55:59]

https://codereview.chromium.org/2995103002/diff/1/runtime/lib/timer_impl.dart
File runtime/lib/timer_impl.dart (right):

https://codereview.chromium.org/2995103002/diff/1/runtime/lib/timer_impl.dart...
runtime/lib/timer_impl.dart:387: _notifyEventHandler();
On 2017/08/16 21:46:56, zra wrote:
> Would it be okay to only notify the event handler if an event needed to be
> requeued, or do you need to do it every time?

Even if no timers needs to be requeued, there may be an existing timer we need
to set a new wakeup for. Compare the use of _notifyEventHandler() in
_handleMessage, which gets skipped there is an unhandled exception.

[zra, 2017-08-16 22:12:58]

lgtm

[Lasse Reichstein Nielsen, 2017-08-17 08:10:52]

lrn@google.com changed reviewers:
+ lrn@google.com

[Lasse Reichstein Nielsen, 2017-08-17 08:10:54]

Super! (ltgm, but what do I know :)

[rmacnak, 2017-08-17 18:34:34]

Description was changed from

==========
[vm] Prevent non-fatal errors from causing timers to be dropped.

Issue #30425
==========

to

==========
[vm] Prevent non-fatal errors from causing timers to be dropped.

Issue #30425

R=zra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/8692f618f6a71f3e47f6ecf18ab45a1fb0df696b
==========

[rmacnak, 2017-08-17 18:34:36]

Committed patchset #1 (id:1) manually as
8692f618f6a71f3e47f6ecf18ab45a1fb0df696b (presubmit successful).