Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: tests/isolate/non_fatal_exception_in_timer_callback_test.dart

Issue 2995103002: [vm] Prevent non-fatal errors from causing timers to be dropped. (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/lib/timer_impl.dart ('K') | « runtime/lib/timer_impl.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/isolate/non_fatal_exception_in_timer_callback_test.dart
diff --git a/tests/isolate/non_fatal_exception_in_timer_callback_test.dart b/tests/isolate/non_fatal_exception_in_timer_callback_test.dart
new file mode 100644
index 0000000000000000000000000000000000000000..4568afe635587e2e9a12b20327ef6ed1686bc7db
--- /dev/null
+++ b/tests/isolate/non_fatal_exception_in_timer_callback_test.dart
@@ -0,0 +1,27 @@
+// Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+import 'dart:async';
+import 'dart:isolate';
+import 'dart:io';
+
+main() async {
+ Isolate.current.setErrorsFatal(false);
+
+ new Timer(const Duration(milliseconds: 10), () {
+ print("Timer 1");
+
+ // This unhandled exception should not prevent the second timer from firing.
+ throw "Oh no!";
+ });
+
+ new Timer.periodic(const Duration(milliseconds: 20), (_) {
+ print("Timer 2");
+ exit(0);
+ });
+
+ sleep(const Duration(milliseconds: 30)); //# sleep: ok
+ // With sleep: both timers are due at the same wakeup event.
+ // Without sleep: the timers get separate wakeup events.
+}
« runtime/lib/timer_impl.dart ('K') | « runtime/lib/timer_impl.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698