Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1004)

Issue 2995023002: Add debug names to scopes. (Closed)

Created:
3 years, 4 months ago by ahe
Modified:
3 years, 3 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -50 lines) Patch
M pkg/analyzer/test/generated/parser_fasta_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/builder/procedure_builder.dart View 3 chunks +6 lines, -3 lines 0 comments Download
M pkg/front_end/lib/src/fasta/dill/dill_class_builder.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 8 chunks +13 lines, -9 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_enum_builder.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart View 2 chunks +6 lines, -5 lines 0 comments Download
M pkg/front_end/lib/src/fasta/scope.dart View 4 chunks +20 lines, -10 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/outline_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/source/scope_listener.dart View 8 chunks +12 lines, -12 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/source_library_builder.dart View 2 chunks +6 lines, -3 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/stack_listener.dart View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 6 (2 generated)
ahe
I find this makes debugging a little easier.
3 years, 4 months ago (2017-08-15 11:10:22 UTC) #2
Johnni Winther
lgtm
3 years, 4 months ago (2017-08-15 11:22:45 UTC) #3
Paul Berry
lgtm
3 years, 4 months ago (2017-08-15 16:50:37 UTC) #4
ahe
3 years, 3 months ago (2017-08-29 09:19:58 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1b5cbc76946a984c362a4b2f6a0c6edfa0f58565 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698