Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart

Issue 2995023002: Add debug names to scopes. (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/front_end/lib/src/fasta/kernel/kernel_enum_builder.dart ('k') | pkg/front_end/lib/src/fasta/scope.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart
diff --git a/pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart b/pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart
index b46efb28d340fd8d7ffd9bc2c15e0a78e4d1ed10..926b2423fdcad194c3f69ac4053c3230c9224ebc 100644
--- a/pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart
+++ b/pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart
@@ -134,14 +134,14 @@ class KernelLibraryBuilder
Map<String, MemberBuilder> constructors = declaration.constructors;
Map<String, MemberBuilder> setters = declaration.setters;
- Scope classScope = new Scope(
- members, setters, scope.withTypeVariables(typeVariables),
+ Scope classScope = new Scope(members, setters,
+ scope.withTypeVariables(typeVariables), "class $className",
isModifiable: false);
// When looking up a constructor, we don't consider type variables or the
// library scope.
- Scope constructorScope =
- new Scope(constructors, null, null, isModifiable: false);
+ Scope constructorScope = new Scope(constructors, null, null, "constructors",
+ isModifiable: false);
ClassBuilder cls = new SourceClassBuilder(
documentationComment,
metadata,
@@ -254,8 +254,9 @@ class KernelLibraryBuilder
interfaces,
new Scope(<String, MemberBuilder>{}, <String, MemberBuilder>{},
scope.withTypeVariables(typeVariables),
+ "mixin $name", isModifiable: false),
+ new Scope(constructors, null, null, "constructors",
isModifiable: false),
- new Scope(constructors, null, null, isModifiable: false),
this,
<ConstructorReferenceBuilder>[],
charOffset,
« no previous file with comments | « pkg/front_end/lib/src/fasta/kernel/kernel_enum_builder.dart ('k') | pkg/front_end/lib/src/fasta/scope.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698