Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2994973002: Implement type variables on local function declarations and expressions. (Closed)

Created:
3 years, 4 months ago by ahe
Modified:
3 years, 4 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update expectation files after adding copyright. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+307 lines, -147 lines) Patch
M pkg/analyzer/lib/src/fasta/ast_builder.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_kernel_test.dart View 1 chunk +0 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/parser/node_listener.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 7 chunks +54 lines, -49 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/parser/listener.dart View 2 chunks +8 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/parser/parser.dart View 13 chunks +88 lines, -74 lines 0 comments Download
M pkg/front_end/lib/src/incremental/unlinked_unit.dart View 1 chunk +4 lines, -3 lines 0 comments Download
A pkg/front_end/testcases/arrow_function.dart View 1 chunk +5 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/arrow_function.dart.direct.expect View 1 chunk +6 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/arrow_function.dart.outline.expect View 1 chunk +6 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/arrow_function.dart.strong.expect View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/ast_builder.status View 2 chunks +3 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/compile.status View 1 chunk +0 lines, -1 line 0 comments Download
A pkg/front_end/testcases/illegal_named_function_expression.dart View 1 chunk +9 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/illegal_named_function_expression.dart.direct.expect View 1 1 chunk +10 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/illegal_named_function_expression.dart.outline.expect View 1 chunk +5 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/illegal_named_function_expression.dart.strong.expect View 1 1 chunk +10 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/illegal_named_function_expression_scope.dart View 1 chunk +8 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/illegal_named_function_expression_scope.dart.direct.expect View 1 1 chunk +9 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/illegal_named_function_expression_scope.dart.outline.expect View 1 chunk +5 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/illegal_named_function_expression_scope.dart.strong.expect View 1 1 chunk +9 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/downwards_inference_on_function_of_t_using_the_t.dart.direct.expect View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/generic_functions_return_typedef.dart.direct.expect View 1 chunk +1 line, -1 line 0 comments Download
A pkg/front_end/testcases/local_generic_function.dart View 1 chunk +8 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/local_generic_function.dart.direct.expect View 1 chunk +9 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/local_generic_function.dart.outline.expect View 1 chunk +5 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/local_generic_function.dart.strong.expect View 1 chunk +9 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/regress/issue_29937.dart.direct.expect View 1 chunk +1 line, -1 line 0 comments Download
A pkg/front_end/testcases/regress/issue_29942.dart.direct.expect View 1 chunk +7 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/regress/issue_29942.dart.strong.expect View 1 chunk +7 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/regress/issue_29978.dart.direct.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/regress/issue_29979.dart.direct.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/testcases/strong.status View 2 chunks +4 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 2993993002 Patch 80001

Messages

Total messages: 7 (2 generated)
ahe
I would like Dan to review these changes, but it would also be great if ...
3 years, 4 months ago (2017-08-14 11:35:04 UTC) #2
danrubel
LGTM https://codereview.chromium.org/2994973002/diff/1/pkg/front_end/lib/src/fasta/kernel/body_builder.dart File pkg/front_end/lib/src/fasta/kernel/body_builder.dart (right): https://codereview.chromium.org/2994973002/diff/1/pkg/front_end/lib/src/fasta/kernel/body_builder.dart#newcode1064 pkg/front_end/lib/src/fasta/kernel/body_builder.dart:1064: scopeLookup(Scope scope, String name, Token token, It is ...
3 years, 4 months ago (2017-08-14 14:08:04 UTC) #3
Paul Berry
I skimmed the changes and didn't see any obvious problems.
3 years, 4 months ago (2017-08-14 15:50:28 UTC) #4
ahe
Thank you, Dan and Paul! https://codereview.chromium.org/2994973002/diff/1/pkg/front_end/lib/src/fasta/kernel/body_builder.dart File pkg/front_end/lib/src/fasta/kernel/body_builder.dart (right): https://codereview.chromium.org/2994973002/diff/1/pkg/front_end/lib/src/fasta/kernel/body_builder.dart#newcode1064 pkg/front_end/lib/src/fasta/kernel/body_builder.dart:1064: scopeLookup(Scope scope, String name, ...
3 years, 4 months ago (2017-08-15 08:59:29 UTC) #5
ahe
3 years, 4 months ago (2017-08-15 09:21:11 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
07cf2557edab22705854521f3003b613cbecd5fd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698