Implement erasure of local function declarations.

Implement erasure of local function declarations.

R=kmillikin@google.com

Committed: https://github.com/dart-lang/sdk/commit/ec258a4ae9570ad8c857863074ae888f7eedadc6

[ahe, 2017-08-09 12:37:47]

ahe@google.com changed reviewers:
+ johnniwinther@google.com, kmillikin@google.com, paulberry@google.com

[Kevin Millikin (Google), 2017-08-09 12:43:42]

lgtm

[ahe, 2017-08-14 08:11:24]

Kevin, PTAL. I had to make some adjustments after you reviewed this code: most
often, the list of type variables is a const list which throws an error when you
call clear (just to be annoying, I guess).

[Kevin Millikin (Google), 2017-08-14 10:47:36]

LGTM but I spotted a typo in a comment.

https://codereview.chromium.org/2993993002/diff/40001/pkg/kernel/lib/transfor...
File pkg/kernel/lib/transformations/erasure.dart (right):

https://codereview.chromium.org/2993993002/diff/40001/pkg/kernel/lib/transfor...
pkg/kernel/lib/transformations/erasure.dart:70: // FunctionType is often assumed
to immutable, we return a copy.
"to immutable" ==> "to be immutable"

[ahe, 2017-08-14 15:26:58]

Samir, this is the CL we just discussed.

[ahe, 2017-08-15 08:27:20]

Thank you, Kevin!

[ahe, 2017-08-15 08:37:15]

Description was changed from

==========
Implement erasure of local function declarations.
==========

to

==========
Implement erasure of local function declarations.

R=kmillikin@google.com

Committed:
https://github.com/dart-lang/sdk/commit/ec258a4ae9570ad8c857863074ae888f7eedadc6
==========

[ahe, 2017-08-15 08:37:17]

Committed patchset #5 (id:80001) manually as
ec258a4ae9570ad8c857863074ae888f7eedadc6 (presubmit successful).