Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2994833002: [Telemetry] Change API of ShouldStopBrowserAfterStoryRun (Closed)

Created:
3 years, 4 months ago by perezju
Modified:
3 years, 4 months ago
Reviewers:
nednguyen
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[Telemetry] Change API of ShouldStopBrowserAfterStoryRun Some clients that will override this shared state method need to know what the current story is to decide whether the browser should be closed or not. BUG=chromium:748566 Review-Url: https://codereview.chromium.org/2994833002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/5b7f1a76070bcbac5af706cdf89b7bcdbb68f380

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M telemetry/telemetry/page/shared_page_state.py View 3 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
perezju
This small change needed to unblock src-side clients making the switch. Nobody is using or ...
3 years, 4 months ago (2017-08-10 13:40:08 UTC) #2
nednguyen
lgtm I guess these are ones with story.startup_url?
3 years, 4 months ago (2017-08-10 14:06:25 UTC) #3
perezju
On 2017/08/10 14:06:25, nednguyen wrote: > lgtm > > I guess these are ones with ...
3 years, 4 months ago (2017-08-10 14:20:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2994833002/1
3 years, 4 months ago (2017-08-10 14:24:54 UTC) #6
commit-bot: I haz the power
3 years, 4 months ago (2017-08-10 15:18:10 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698