Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 2994593004: [annotee] add SOURCE_MANIFEST annotation. (Closed)

Created:
3 years, 4 months ago by iannucci
Modified:
3 years, 4 months ago
Reviewers:
dnj, Ryan Tseng, hinoka
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

[annotee] add SOURCE_MANIFEST annotation. This also changes the sha256 key to be bytes instead of string. R=dnj@chromium.org, hinoka@chromium.org BUG= Review-Url: https://codereview.chromium.org/2994593004 Committed: https://github.com/luci/luci-go/commit/df8718467512453e74523cffd6679e59f05abfb3

Patch Set 1 #

Total comments: 2

Patch Set 2 : Move to coverage test #

Patch Set 3 : rename to deployment_manifests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -85 lines) Patch
M common/proto/milo/annotations.proto View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M common/proto/milo/annotations.pb.go View 1 2 5 chunks +82 lines, -79 lines 0 comments Download
M logdog/client/annotee/annotation/annotation.go View 1 2 2 chunks +30 lines, -1 line 0 comments Download
M logdog/client/annotee/annotation/annotation_test.go View 1 2 chunks +3 lines, -3 lines 0 comments Download
M logdog/client/annotee/annotation/test_data/coverage.annotations.txt View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
M logdog/client/annotee/annotation/test_expectations/coverage_base.proto.txt View 1 2 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
iannucci
3 years, 4 months ago (2017-08-04 22:48:15 UTC) #1
dnj
lgtm w/ comment, take it or leave it. https://codereview.chromium.org/2994593004/diff/1/logdog/client/annotee/annotation/annotation_test.go File logdog/client/annotee/annotation/annotation_test.go (right): https://codereview.chromium.org/2994593004/diff/1/logdog/client/annotee/annotation/annotation_test.go#newcode282 logdog/client/annotee/annotation/annotation_test.go:282: {"source_manifest", ...
3 years, 4 months ago (2017-08-04 23:50:07 UTC) #2
Ryan Tseng
lgtm
3 years, 4 months ago (2017-08-05 00:20:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2994593004/20001
3 years, 4 months ago (2017-08-05 00:26:35 UTC) #7
iannucci
https://codereview.chromium.org/2994593004/diff/1/logdog/client/annotee/annotation/annotation_test.go File logdog/client/annotee/annotation/annotation_test.go (right): https://codereview.chromium.org/2994593004/diff/1/logdog/client/annotee/annotation/annotation_test.go#newcode282 logdog/client/annotee/annotation/annotation_test.go:282: {"source_manifest", nil}, On 2017/08/04 23:50:07, dnj wrote: > Idunno, ...
3 years, 4 months ago (2017-08-05 00:27:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2994593004/40001
3 years, 4 months ago (2017-08-05 00:31:55 UTC) #12
commit-bot: I haz the power
3 years, 4 months ago (2017-08-05 00:40:57 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://github.com/luci/luci-go/commit/df8718467512453e74523cffd6679e59f05abfb3

Powered by Google App Engine
This is Rietveld 408576698