Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2994473002: Reland of Make rendering of MediaStreams reflect changes to its set of tracks. (Closed)

Created:
3 years, 4 months ago by Guido Urdaneta
Modified:
3 years, 4 months ago
CC:
blink-reviews, blink-reviews-html_chromium.org, chfremer+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, jam, jochen+watch_chromium.org, mlamouri+watch-blink_chromium.org, mlamouri+watch-content_chromium.org, Peter Beverloo, posciak+watch_chromium.org, nessy, Srirama
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Make rendering of MediaStreams reflect changes to its set of tracks. (patchset #1 id:1 of https://codereview.chromium.org/2985393002/ ) Reason for revert: BUILD files have been fixed in a separate CL, so this is safe to reland. Original issue's description: > Revert of Make rendering of MediaStreams reflect changes to its set of tracks. (patchset #6 id:120001 of https://codereview.chromium.org/2969093002/ ) > > Reason for revert: > Breaking build https://uberchromegw.corp.google.com/i/chromium.linux/builders/Cast%20Audio%20Linux/builds/3356 > > Original issue's description: > > Make rendering of MediaStreams reflect changes to its set of tracks. > > > > Before this CL, MediaStreams assigned to a media element required > > reassignment of the stream to the element in order to make changes > > to the set of tracks visible. > > > > This CL fixes this problem by making WebMediaPlayerMS subscribe to > > changes in the set of tracks of a MediaStream, and correspondingly > > update audio and video renderers. > > > > BUG=720258 > > > > Review-Url: https://codereview.chromium.org/2969093002 > > Cr-Commit-Position: refs/heads/master@{#490906} > > Committed: https://chromium.googlesource.com/chromium/src/+/c9612ba8bf66e48a32301e35425dd3384f48a3d8 > > TBR=dalecurtis@chromium.org,emircan@chromium.org,foolip@chromium.org,mkwst@chromium.org,guidou@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=720258 > > Review-Url: https://codereview.chromium.org/2985393002 > Cr-Commit-Position: refs/heads/master@{#490920} > Committed: https://chromium.googlesource.com/chromium/src/+/b35b4c271b7819e3661942ab2c72083673722910 TBR=dalecurtis@chromium.org,emircan@chromium.org,foolip@chromium.org,mkwst@chromium.org,jkrcal@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=720258 Review-Url: https://codereview.chromium.org/2994473002 Cr-Commit-Position: refs/heads/master@{#491341} Committed: https://chromium.googlesource.com/chromium/src/+/92561aec1fac0748d4e0ac3618ed7d2eb6ea9cb0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+346 lines, -13 lines) Patch
M content/browser/webrtc/webrtc_getusermedia_browsertest.cc View 1 chunk +35 lines, -0 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms.h View 5 chunks +16 lines, -1 line 0 comments Download
M content/renderer/media/webmediaplayer_ms.cc View 8 chunks +157 lines, -9 lines 0 comments Download
M content/shell/test_runner/mock_web_user_media_client.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M content/test/data/media/getusermedia.html View 1 chunk +138 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Guido Urdaneta
Created Reland of Make rendering of MediaStreams reflect changes to its set of tracks.
3 years, 4 months ago (2017-08-02 09:52:28 UTC) #1
foolip
lgtm
3 years, 4 months ago (2017-08-02 10:01:19 UTC) #6
jkrcal
from previous sheriff's perspective: lgtm
3 years, 4 months ago (2017-08-02 10:48:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2994473002/1
3 years, 4 months ago (2017-08-02 11:17:22 UTC) #10
commit-bot: I haz the power
3 years, 4 months ago (2017-08-02 12:04:11 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/92561aec1fac0748d4e0ac3618ed...

Powered by Google App Engine
This is Rietveld 408576698