Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 2994433002: Milo: Add links to console in config page (Closed)

Created:
3 years, 4 months ago by Ryan Tseng
Modified:
3 years, 4 months ago
Reviewers:
dnj, tandrii(chromium)
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M milo/frontend/appengine/templates/pages/configs.html View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
Ryan Tseng
ptal small change, i think everyone else is afk today For convenience, demo: https://luci-milo-dev.appspot.com/admin/configs
3 years, 4 months ago (2017-08-01 18:51:53 UTC) #6
tandrii(chromium)
lgtm but i can't see the page (error 403) :(
3 years, 4 months ago (2017-08-01 18:54:25 UTC) #8
dnj
lgtm
3 years, 4 months ago (2017-08-01 18:54:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2994433002/1
3 years, 4 months ago (2017-08-01 18:55:32 UTC) #11
commit-bot: I haz the power
3 years, 4 months ago (2017-08-01 18:59:47 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/043acb1a6ac0d13f149d40f01b40197b2dda4c4b

Powered by Google App Engine
This is Rietveld 408576698