Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 299443017: Add unittests for action_runner.BeginInteraction and action_runner.EndInteraction. (Closed)

Created:
6 years, 7 months ago by nednguyen
Modified:
6 years, 7 months ago
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add unittests for action_runner.BeginInteraction and action_runner.EndInteraction. This is a reland of https://codereview.chromium.org/294943006 after it's reverted in https://codereview.chromium.org/284183014/. BUG=368767 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272782

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -0 lines) Patch
A tools/telemetry/telemetry/page/actions/action_runner_unittest.py View 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
nednguyen
6 years, 7 months ago (2014-05-23 18:23:42 UTC) #1
nduca
lgtm
6 years, 7 months ago (2014-05-23 23:21:27 UTC) #2
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 7 months ago (2014-05-23 23:21:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/299443017/1
6 years, 7 months ago (2014-05-23 23:23:34 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-24 04:53:32 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-24 07:05:44 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/builds/32385)
6 years, 7 months ago (2014-05-24 07:05:44 UTC) #7
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 7 months ago (2014-05-24 17:55:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/299443017/1
6 years, 7 months ago (2014-05-24 23:19:53 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-26 04:13:18 UTC) #10
Message was sent while issue was closed.
Change committed as 272782

Powered by Google App Engine
This is Rietveld 408576698