Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 294943006: Add test for action_runner.BeginInteraction and action_runner.EndInteraction. (Closed)

Created:
6 years, 7 months ago by nednguyen
Modified:
6 years, 7 months ago
Reviewers:
dtu, nduca, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add test for action_runner.BeginInteraction and action_runner.EndInteraction. BUG=368767 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272549

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Revert unnecessary changes due to mistakes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -0 lines) Patch
A tools/telemetry/telemetry/page/actions/action_runner_unittest.py View 1 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
nednguyen
I believe this will catch the race condition. I will check this against oilpan build ...
6 years, 7 months ago (2014-05-21 01:37:15 UTC) #1
tonyg
lgtm Thanks!
6 years, 7 months ago (2014-05-21 07:03:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/294943006/1
6 years, 7 months ago (2014-05-21 07:05:51 UTC) #3
nednguyen
The CQ bit was unchecked by nednguyen@google.com
6 years, 7 months ago (2014-05-21 17:52:39 UTC) #4
nednguyen
On 2014/05/21 17:52:39, nednguyen wrote: > The CQ bit was unchecked by mailto:nednguyen@google.com Try this ...
6 years, 7 months ago (2014-05-21 17:53:36 UTC) #5
nednguyen
On 2014/05/21 17:53:36, nednguyen wrote: > On 2014/05/21 17:52:39, nednguyen wrote: > > The CQ ...
6 years, 7 months ago (2014-05-22 16:45:28 UTC) #6
nednguyen
On 2014/05/22 16:45:28, nednguyen wrote: > On 2014/05/21 17:53:36, nednguyen wrote: > > On 2014/05/21 ...
6 years, 7 months ago (2014-05-23 16:51:22 UTC) #7
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 7 months ago (2014-05-23 16:51:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/294943006/1
6 years, 7 months ago (2014-05-23 16:52:47 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-23 16:54:45 UTC) #10
Message was sent while issue was closed.
Change committed as 272549

Powered by Google App Engine
This is Rietveld 408576698