Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2994223002: Restore "Add current rss and embedder name to Observatory" (Closed)

Created:
3 years, 4 months ago by cbernaschina
Modified:
3 years, 4 months ago
Reviewers:
bkonyi, rmacnak
CC:
reviews_dartlang.org, turnidge, rmacnak, zra, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Restore "Add current rss and embedder name to Observatory" Made benchmark_test.cc independent from Service by using the implementation of MaxRSS from bin::Process Related https://github.com/dart-lang/sdk/commit/ce736d3ef009bf334a92d5b7d354fc0b04805b4f R=bkonyi@google.com TBR=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/0cbbeeb2884e7f9aa28d800e620c3a0f77022a81

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+332 lines, -119 lines) Patch
M runtime/bin/main.cc View 2 chunks +11 lines, -0 lines 0 comments Download
M runtime/bin/process_android.cc View 1 chunk +12 lines, -10 lines 0 comments Download
M runtime/bin/process_linux.cc View 1 chunk +12 lines, -10 lines 0 comments Download
M runtime/include/dart_tools_api.h View 1 chunk +43 lines, -0 lines 0 comments Download
M runtime/observatory/lib/models.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/repositories.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/app/page.dart View 3 chunks +4 lines, -3 lines 0 comments Download
M runtime/observatory/lib/src/elements/memory/dashboard.dart View 4 chunks +9 lines, -4 lines 0 comments Download
M runtime/observatory/lib/src/elements/memory/graph.dart View 11 chunks +60 lines, -34 lines 0 comments Download
M runtime/observatory/lib/src/elements/vm_view.dart View 7 chunks +42 lines, -5 lines 0 comments Download
M runtime/observatory/lib/src/models/objects/vm.dart View 2 chunks +3 lines, -0 lines 0 comments Download
A runtime/observatory/lib/src/models/repositories/vm.dart View 1 chunk +9 lines, -0 lines 0 comments Download
A runtime/observatory/lib/src/repositories/vm.dart View 1 chunk +14 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 3 chunks +7 lines, -7 lines 0 comments Download
M runtime/observatory/observatory_sources.gypi View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/objects/vm.dart View 2 chunks +4 lines, -0 lines 0 comments Download
M runtime/observatory/tests/service/vm_test.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/vm/benchmark_test.cc View 2 chunks +2 lines, -1 line 0 comments Download
M runtime/vm/dart_api_impl.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M runtime/vm/metrics.h View 2 chunks +6 lines, -0 lines 0 comments Download
M runtime/vm/metrics.cc View 1 chunk +5 lines, -1 line 0 comments Download
M runtime/vm/os.h View 1 chunk +0 lines, -3 lines 0 comments Download
M runtime/vm/os_android.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M runtime/vm/os_fuchsia.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M runtime/vm/os_linux.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M runtime/vm/os_macos.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M runtime/vm/os_win.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M runtime/vm/service.h View 4 chunks +9 lines, -0 lines 0 comments Download
M runtime/vm/service.cc View 4 chunks +59 lines, -1 line 0 comments Download

Messages

Total messages: 7 (4 generated)
cbernaschina
3 years, 4 months ago (2017-08-14 23:27:36 UTC) #1
bkonyi
lgtm
3 years, 4 months ago (2017-08-14 23:50:22 UTC) #4
cbernaschina
3 years, 4 months ago (2017-08-15 00:02:38 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
0cbbeeb2884e7f9aa28d800e620c3a0f77022a81.

Powered by Google App Engine
This is Rietveld 408576698