Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1692)

Unified Diff: runtime/observatory/lib/src/elements/memory/dashboard.dart

Issue 2994223002: Restore "Add current rss and embedder name to Observatory" (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/lib/src/app/page.dart ('k') | runtime/observatory/lib/src/elements/memory/graph.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/lib/src/elements/memory/dashboard.dart
diff --git a/runtime/observatory/lib/src/elements/memory/dashboard.dart b/runtime/observatory/lib/src/elements/memory/dashboard.dart
index 2aa299ef5e5ce237ff25cb4a8d354b8c989a353c..0597fa8217bf54d0574418e00d981842e4f960e1 100644
--- a/runtime/observatory/lib/src/elements/memory/dashboard.dart
+++ b/runtime/observatory/lib/src/elements/memory/dashboard.dart
@@ -41,17 +41,19 @@ class MemoryDashboardElement extends HtmlElement implements Renderable {
Stream<RenderedEvent<MemoryDashboardElement>> get onRendered => _r.onRendered;
M.VMRef _vm;
+ M.VMRepository _vms;
M.IsolateRepository _isolates;
M.EditorRepository _editor;
M.AllocationProfileRepository _allocations;
M.EventRepository _events;
M.NotificationRepository _notifications;
- M.VM get vm => _vm;
+ M.VMRef get vm => _vm;
M.NotificationRepository get notifications => _notifications;
factory MemoryDashboardElement(
- M.VM vm,
+ M.VMRef vm,
+ M.VMRepository vms,
M.IsolateRepository isolates,
M.EditorRepository editor,
M.AllocationProfileRepository allocations,
@@ -59,6 +61,7 @@ class MemoryDashboardElement extends HtmlElement implements Renderable {
M.NotificationRepository notifications,
{RenderingQueue queue}) {
assert(vm != null);
+ assert(vms != null);
assert(isolates != null);
assert(editor != null);
assert(allocations != null);
@@ -67,6 +70,7 @@ class MemoryDashboardElement extends HtmlElement implements Renderable {
MemoryDashboardElement e = document.createElement(tag.name);
e._r = new RenderingScheduler(e, queue: queue);
e._vm = vm;
+ e._vms = vms;
e._isolates = isolates;
e._editor = editor;
e._allocations = allocations;
@@ -96,8 +100,9 @@ class MemoryDashboardElement extends HtmlElement implements Renderable {
void render() {
if (_graph == null) {
- _graph = new MemoryGraphElement(vm, _isolates, _events, queue: _r.queue)
- ..onIsolateSelected.listen(_onIsolateSelected);
+ _graph =
+ new MemoryGraphElement(vm, _vms, _isolates, _events, queue: _r.queue)
+ ..onIsolateSelected.listen(_onIsolateSelected);
}
children = [
navBar([new NavNotifyElement(_notifications, queue: _r.queue)]),
« no previous file with comments | « runtime/observatory/lib/src/app/page.dart ('k') | runtime/observatory/lib/src/elements/memory/graph.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698