Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 2994043002: Revert of Request keyframes more frequently on stream start/decoding error. (Closed)

Created:
3 years, 4 months ago by Taylor Brandstetter
Modified:
3 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, tterriberry_mozilla.com, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Request keyframes more frequently on stream start/decoding error. (patchset #1 id:1 of https://codereview.webrtc.org/2993793002/ ) Reason for revert: Broke downstream test that was waiting for 5 keyframes to be received within 10 seconds. Maybe the issue is that "stats_callback_->OnCompleteFrame(frame->num_references == 0, ..." was changed to "frame->is_keyframe()"? Original issue's description: > Request keyframes more frequently on stream start/decoding error. > > In this CL: > - Added FrameObject::is_keyframe() convinience function. > - Moved logic to request keyframes on decoding error from VideoReceived to > VideoReceiveStream. > - Added keyframe_required as a parameter to FrameBuffer::NextFrame. > > BUG=webrtc:8074 > > Review-Url: https://codereview.webrtc.org/2993793002 > Cr-Commit-Position: refs/heads/master@{#19280} > Committed: https://chromium.googlesource.com/external/webrtc/+/26b48043581735eed6e36b95fae6f5b1bcf8cfb5 TBR=terelius@webrtc.org,stefan@webrtc.org,noahric@chromium.org,philipel@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:8074 Review-Url: https://codereview.webrtc.org/2994043002 Cr-Commit-Position: refs/heads/master@{#19295} Committed: https://chromium.googlesource.com/external/webrtc/+/77a983185f57628cd5955bd2c0a1bf71c30439bb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -43 lines) Patch
M webrtc/modules/video_coding/frame_buffer2.h View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/modules/video_coding/frame_buffer2.cc View 4 chunks +3 lines, -8 lines 0 comments Download
M webrtc/modules/video_coding/frame_buffer2_unittest.cc View 2 chunks +2 lines, -16 lines 0 comments Download
M webrtc/modules/video_coding/frame_object.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/video_receiver.cc View 1 chunk +18 lines, -1 line 0 comments Download
M webrtc/video/video_receive_stream.h View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/video/video_receive_stream.cc View 3 chunks +3 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Taylor Brandstetter
Created Revert of Request keyframes more frequently on stream start/decoding error.
3 years, 4 months ago (2017-08-09 22:55:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2994043002/1
3 years, 4 months ago (2017-08-09 22:55:32 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/77a983185f57628cd5955bd2c0a1bf71c30439bb
3 years, 4 months ago (2017-08-09 22:55:51 UTC) #6
philipel
3 years, 4 months ago (2017-08-10 08:36:35 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2996823002/ by philipel@webrtc.org.

The reason for reverting is: Create fix CL..

Powered by Google App Engine
This is Rietveld 408576698