Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2993943002: swarming: use df's -l argument (Closed)

Created:
3 years, 4 months ago by M-A Ruel
Modified:
3 years, 4 months ago
Reviewers:
Vadim Sh.
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

swarming: use df's -l argument This doesn't have an effect on Ubuntu but does on OSX, as it trims 'map -hosts' and 'map auto_home' which confuses df output processing due to whitespace. This is not a big deal, just cleanup work. Manually tested on OSX 10.9, 10.12, Ubuntu 14.04 and 16.04. R=vadimsh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2993943002 Committed: https://github.com/luci/luci-py/commit/5fbd31970425a9c0094839c99b63d8bfde605ee9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M appengine/swarming/swarming_bot/api/platforms/posix.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
M-A Ruel
3 years, 4 months ago (2017-08-08 15:49:58 UTC) #1
Vadim Sh.
lgtm
3 years, 4 months ago (2017-08-08 18:25:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2993943002/1
3 years, 4 months ago (2017-08-08 18:26:12 UTC) #4
commit-bot: I haz the power
3 years, 4 months ago (2017-08-08 18:30:11 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-py/commit/5fbd31970425a9c0094839c99b63d8bfde605ee9

Powered by Google App Engine
This is Rietveld 408576698