Issue 299383002: Revert of Don't expose --disable-gpu-compositing, only set internally.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 299383002: Revert of Don't expose --disable-gpu-compositing, only set internally. (Closed)

Created:
6 years, 7 months ago by alph

Modified:
6 years, 7 months ago

Reviewers:
jbauman, piman

CC:
chromium-reviews, creis+watch_chromium.org, nkostylev+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Revert of Don't expose --disable-gpu-compositing, only set internally. (https://codereview.chromium.org/300523002/) Reason for revert: Makes a bunch of virtual/softwarecompositing tests Timeout on Mac https://code.google.com/p/chromium/issues/detail?id=377145 Original issue's description: > Don't expose --disable-gpu-compositing, only set internally. > > The flag isn't meant to be set externally, it doesn't work on most > configs. It's only meant internally to make sure the renderer doesn't > try to use GPU when the browser is in software. > > BUG=None > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272636 TBR=jbauman@chromium.org,piman@chromium.org NOTREECHECKS=true NOTRY=true BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272707

Patch Set 1 #

Created: 6 years, 7 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -1 line)			Patch
M	chrome/browser/chromeos/login/chrome_restart_request.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/renderer_host/render_process_host_impl.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/public/common/content_switches.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

alph

Created Revert of Don't expose --disable-gpu-compositing, only set internally.

6 years, 7 months ago (2014-05-24 09:21:32 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alph@chromium.org/299383002/1

6 years, 7 months ago (2014-05-24 09:21:53 UTC) #2

Message was sent while issue was closed.

Change committed as 272707

Expand Messages | Collapse Messages