[scheduler]: ACLs phase 2 - warn if Job/Trigger don't have ACLs.

scheduler/appengine/catalog/catalog_test.go

Index: scheduler/appengine/catalog/catalog_test.go
diff --git a/scheduler/appengine/catalog/catalog_test.go b/scheduler/appengine/catalog/catalog_test.go
index 57d2f0220763ae5fecbb24650bedd0d366370692..f98a522a2d2e0c6e21ca449e73a781d4dfddfbed 100644
--- a/scheduler/appengine/catalog/catalog_test.go
+++ b/scheduler/appengine/catalog/catalog_test.go
@@ -208,36 +208,43 @@ func TestConfigReading(t *testing.T) {
 				{
 					JobID:    "project1/noop-job-1",
 					Acls:     acl.GrantsByRole{Readers: []string{"group:all"}, Owners: []string{"group:some-admins"}},
-					Revision: "847cf9c217f7bad214805f3bea7a30799383940b",
+					Revision: "ad93dac7f33309b6e5f3b53d6206d1b9361f83db",
 					Schedule: "*/10 * * * * * *",
 					Task:     []uint8{0xa, 0x0},
 				},
 				{
 					JobID:    "project1/noop-job-2",
 					Acls:     acl.GrantsByRole{Readers: []string{"group:all"}, Owners: []string{"group:some-admins"}},
-					Revision: "847cf9c217f7bad214805f3bea7a30799383940b",
+					Revision: "ad93dac7f33309b6e5f3b53d6206d1b9361f83db",
 					Schedule: "*/10 * * * * * *",
 					Task:     []uint8{0xa, 0x0},
 				},
+				{
+					JobID:    "project1/missing-acls",
+					Acls:     acl.GrantsByRole{[]string{}, []string{}},
+					Revision: "ad93dac7f33309b6e5f3b53d6206d1b9361f83db",
+					Schedule: "*/5 * * * * * *",
+					Task:     []uint8{0xa, 0x0},
+				},
 				{
 					JobID:    "project1/urlfetch-job-1",
 					Acls:     acl.GrantsByRole{Readers: []string{"group:all"}, Owners: []string{"group:debuggers", "group:some-admins"}},
-					Revision: "847cf9c217f7bad214805f3bea7a30799383940b",
+					Revision: "ad93dac7f33309b6e5f3b53d6206d1b9361f83db",
 					Schedule: "*/10 * * * * * *",
 					Task:     []uint8{18, 21, 18, 19, 104, 116, 116, 112, 115, 58, 47, 47, 101, 120, 97, 109, 112, 108, 101, 46, 99, 111, 109},
 				},
 				{
 					JobID:    "project1/urlfetch-job-2",
 					Acls:     acl.GrantsByRole{Readers: []string{"group:all"}, Owners: []string{"group:some-admins"}},
-					Revision: "847cf9c217f7bad214805f3bea7a30799383940b",
+					Revision: "ad93dac7f33309b6e5f3b53d6206d1b9361f83db",
 					Schedule: "*/10 * * * * * *",
 					Task:     []uint8{18, 21, 18, 19, 104, 116, 116, 112, 115, 58, 47, 47, 101, 120, 97, 109, 112, 108, 101, 46, 99, 111, 109},
 				},
 			})
 
 			// Make sure URL fetch jobs are parsed correctly and identically.
-			newStyleDef := defs[2].Task
-			oldStyleDef := defs[3].Task
+			newStyleDef := defs[3].Task
+			oldStyleDef := defs[4].Task
 			So(newStyleDef, ShouldResemble, oldStyleDef)
 			msg := messages.TaskDefWrapper{}
 			proto.Unmarshal(newStyleDef, &msg)
@@ -372,6 +379,13 @@ job {
   noop: {}
 }
 
+job {
+  id: "missing-acls"
+  schedule: "*/5 * * * * * *"
+
+  noop: {}
+}
+
 job {
   id: "urlfetch-job-1"
   schedule: "*/10 * * * * * *"